Skip to content

[Tooling] Update CLI to support key management (Issue #489)#524

Merged
h5law merged 40 commits intomainfrom
add_keybase_cli_endpoints
Feb 23, 2023
Merged

[Tooling] Update CLI to support key management (Issue #489)#524
h5law merged 40 commits intomainfrom
add_keybase_cli_endpoints

Conversation

@h5law
Copy link
Copy Markdown
Contributor

@h5law h5law commented Feb 17, 2023 •
edited
Loading

Description

This PR adds the Keys endpoint to the CLI and adds the relevant subcommands to interact with the keybase from the users' perspective.

The new Keys namespace allows for CRUD operations on keys and gives users access to creating, importing and exporting keys (as a raw string or JSON encoded string), deleting keys, listing all keys and getting specific keys as well as signing and verifying hex-encoded byte messages.

image

image

Issue

Fixes #489

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Add Keys CLI namespace
  • Add keybase-related subcommands
  • Return keypair when importing or creating a new key
  • Reformat tests
  • Remove Exists() function from keybase interface

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law added core Core infrastructure - protocol related tooling tooling to support development, testing et al labels Feb 17, 2023
@h5law h5law added this to the M1: Pocket PoS (Proof of Stake) milestone Feb 17, 2023
@h5law h5law self-assigned this Feb 17, 2023
@h5law h5law requested a review from Olshansk February 17, 2023 10:57
Olshansk
Olshansk requested changes Feb 17, 2023
View reviewed changes
@h5law h5law requested a review from Olshansk February 18, 2023 12:45
Olshansk
Olshansk requested changes Feb 20, 2023
View reviewed changes
@h5law h5law requested a review from Olshansk February 21, 2023 21:56
Olshansk
Olshansk requested changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h5law A few (minor) outstanding NITS from my previous review but otherwise LGTM. The new additions for signing transactions are 🔥

@h5law h5law requested a review from Olshansk February 23, 2023 01:59
Olshansk
Olshansk approved these changes Feb 23, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another piece of solid work 🤝

:shipit:

@h5law h5law merged commit 9a5e711 into main Feb 23, 2023
@h5law h5law deleted the add_keybase_cli_endpoints branch February 23, 2023 12:53
bryanchriswhite added a commit that referenced this pull request Feb 23, 2023
@bryanchriswhite
revert: Merge remote-tracking branch 'pokt/issue/improve_test_failure…
6d71f72 
…_reporting' into chore/libp2p-1

* pokt/issue/improve_test_failure_reporting:
  feat(tooling): return failed tests full output
  [Tooling] Update CLI to support key management (Issue #489) (#524)
bryanchriswhite added a commit that referenced this pull request Feb 24, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/libp2p-1
8768593 
* pokt/main:
  [Tooling] Returning failed tests full output (#542)
  [Tooling] Update CLI to support key management (Issue #489) (#524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@h5law h5law

Labels

core Core infrastructure - protocol related tooling tooling to support development, testing et al

Projects

V1 Dashboard
Status: Done

Milestone

M1: Pocket PoS (Proof of Stake)

Development

Successfully merging this pull request may close these issues.

[Tooling] Update CLI to support key management

2 participants

@h5law @Olshansk