Conversation
|
Currently working in #366 (comment) |
|
@Gustavobelfort For future reference, please make sure to update all the "logistical" things:
E.g. the "list of changes" is actually the list of issues that should be in the Will let you give you a shot and lmk if you have any questions after updating |
Olshansk
left a comment
There was a problem hiding this comment.
@Gustavobelfort Looking really good so far! Took a first round of review with some comments and questions.
Olshansk
left a comment
There was a problem hiding this comment.
@Gustavobelfort Looking really good so far! Took a first round of review with some comments and questions.
Olshansk
left a comment
There was a problem hiding this comment.
Thank you for updating the PR description!
Also, any reason to keep this as a draft?
|
@Gustavobelfort Let me know when this is ready for another look! |
Olshansk
left a comment
There was a problem hiding this comment.
Looks great, thank you @Gustavobelfort! 🙌
What we usually do is "Squash & Merge" + Put the PR description as the body of the commit. Go for it :)

Description
This pr is responsible for both implementing targets to build the pocket binaries defined in the
app/folder and for refactoring the help targets/comments used in the root makefile into cleaner and more readable commands.The build targets also take in consideration the naming requirements for the binaries and allow them to be changed easily without having to change any package names.
Issue
Fixes #366
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)