Skip to content

Commit 17a3724

Browse files
[Tooling] Create build makefile (#390)
<!-- 1. Make the title of the PR is descriptive and follows this format: `[<Module>] <DESCRIPTION>` 2. Update the _Assigness_, _Labels_, _Projects_, _Milestone_ before submitting the PR for review. 3. Add label(s) for the purpose (e.g. `persistence`) and, if applicable, priority (e.g. `low`) labels as well. --> ## Description This pr is responsible for both implementing targets to build the pocket binaries defined in the `app/` folder and for refactoring the help targets/comments used in the root makefile into cleaner and more readable commands. The build targets also take in consideration the naming requirements for the binaries and allow them to be changed easily without having to change any package names. ## Issue Fixes #366 ## Type of change Please mark the relevant option(s): - [x] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes <!-- List out all the changes made--> - Splits root Makefile into multiple files - Implements build targets to generate pocket binaries - Refactor pocket help Makefile targets and comments ## Testing - [x] `make develop_test` - [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` <!-- If you added additional tests or infrastructure, describe it here. Bonus points for images and videos or gifs. --> ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
1 parent 39302d6 commit 17a3724

4 files changed

Lines changed: 167 additions & 129 deletions

File tree

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,7 @@ rpc/server.gen.go
6060
rpc/client.gen.go
6161

6262
# Ignored generated files by build/config/main.go
63-
build/config/gen*.json
63+
build/config/gen*.json
64+
65+
# Ignored generated files by build
66+
bin/*

0 commit comments

Comments
 (0)