Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions ADRs/ADR0005-rename-fishermen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Rename Fishermen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanlott Do you want to share you discussion with the community?

Happy to do it on your behalf but think it's also a great way to reach out!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to find this discussion but it seems that it has been removed. is it moving to the forum?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


* Status: Draft
* Deciders: Protocol Network Team
* Date: 2023-04-25

## Context and Problem Statement

Fishermen is a canonically used term in [blockchain technology](https://wiki.polkadot.network/docs/learn-availability#fishermen-deprecated). In POKT Network, Fishermen are actors responsible for monitoring & reporting the behavior of Service nodes. However, the term Fishermen is ambiguous, overloaded, and doesn't describe its responsibilities in the protocol without additional context. None of other POKT actor roles have a maritime or sea based theme, further adding to the confusion. Additionally, pluralization preferences and spelling of `fishermen` is an ongoing issue in the codebase. For example, there are TODO comments about renaming `fisherman` to `fishermen`.

## Decision Drivers

- Clarity in names is important
- Uniformity in pluralization and spelling
- Gender neutrality

## Considered Options

- Auditor
- Checker
- Verifier
- Sampler
- Watcher

## Decision Outcome

_Decision pending further discussion & community input_.

### Positive Consequences

- It is clearer what the actor is called who checks and samples relay data.

### Negative Consequences

- Whitepaper, protocol, documentation, and code-level changes are necessary to accomplish this name change.

## Pros and Cons of the Options

### Option 1: Auditor

### Option 2: Checker

### Option 3: Verifier

- Bad, because it's very close to Validator.

### Option 4: Sampler

### Option 5: Watcher

- Good, because there's precedent.

## Links

- [Pokadot Network - Fishermen Deprecated](https://wiki.polkadot.network/docs/learn-availability#fishermen-deprecated)