generated from pokt-network/repo-template
-
Notifications
You must be signed in to change notification settings - Fork 9
[ADR] 0005 - Rename Fishermen #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Rename Fishermen | ||
|
|
||
| * Status: Draft | ||
| * Deciders: Protocol Network Team | ||
| * Date: 2023-04-25 | ||
|
|
||
| ## Context and Problem Statement | ||
|
|
||
| Fishermen is a canonically used term in [blockchain technology](https://wiki.polkadot.network/docs/learn-availability#fishermen-deprecated). In POKT Network, Fishermen are actors responsible for monitoring & reporting the behavior of Service nodes. However, the term Fishermen is ambiguous, overloaded, and doesn't describe its responsibilities in the protocol without additional context. None of other POKT actor roles have a maritime or sea based theme, further adding to the confusion. Additionally, pluralization preferences and spelling of `fishermen` is an ongoing issue in the codebase. For example, there are TODO comments about renaming `fisherman` to `fishermen`. | ||
|
|
||
| ## Decision Drivers | ||
|
|
||
| - Clarity in names is important | ||
| - Uniformity in pluralization and spelling | ||
| - Gender neutrality | ||
|
|
||
| ## Considered Options | ||
|
|
||
| - Auditor | ||
| - Checker | ||
| - Verifier | ||
| - Sampler | ||
| - Watcher | ||
|
|
||
| ## Decision Outcome | ||
|
|
||
| _Decision pending further discussion & community input_. | ||
|
|
||
| ### Positive Consequences | ||
|
|
||
| - It is clearer what the actor is called who checks and samples relay data. | ||
|
|
||
| ### Negative Consequences | ||
|
|
||
| - Whitepaper, protocol, documentation, and code-level changes are necessary to accomplish this name change. | ||
|
|
||
| ## Pros and Cons of the Options | ||
|
|
||
| ### Option 1: Auditor | ||
|
|
||
| ### Option 2: Checker | ||
|
|
||
| ### Option 3: Verifier | ||
|
|
||
| - Bad, because it's very close to Validator. | ||
|
|
||
| ### Option 4: Sampler | ||
|
|
||
| ### Option 5: Watcher | ||
|
|
||
| - Good, because there's precedent. | ||
|
|
||
| ## Links | ||
|
|
||
| - [Pokadot Network - Fishermen Deprecated](https://wiki.polkadot.network/docs/learn-availability#fishermen-deprecated) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylanlott Do you want to share you discussion with the community?
Happy to do it on your behalf but think it's also a great way to reach out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find this discussion but it seems that it has been removed. is it moving to the forum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pokt-network/pocket#701