Skip to content

rebuild with -fPIC (fbthrift) #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2023
Merged

rebuild with -fPIC (fbthrift) #4513

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04f360d
rebuild with -fPIC
and-ri Dec 20, 2023
f06eaf5
fix path in FBThriftTargets.cmake
and-ri Dec 20, 2023
436c0b2
remove sed command
and-ri Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions projects/facebook.com/fbthrift/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ build:
- cmake -S . -B build/shared $CMAKE_ARGS
- cmake --build build/shared
- cmake --install build/shared
- run: |
sed -i.bak "s|{{pkgx.prefix}}|\${_IMPORT_PREFIX}/../../..|g" FBThriftTargets.cmake
Copy link
Contributor

@jhheider jhheider Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be handled by fix-up.ts in brewkit (though it currently has a bug being fixed in pkgxdev/brewkit#233

rm -f FBThriftTargets.cmake.bak
working-directory: ${{prefix}}/lib/cmake/fbthrift
env:
CMAKE_ARGS:
- -DCMAKE_INSTALL_PREFIX="{{prefix}}
Expand All @@ -36,6 +40,11 @@ build:
- -DCMAKE_VERBOSE_MAKEFILE=ON
- -Wno-dev
- -DBUILD_TESTING=OFF
linux:
CMAKE_ARGS:
- -DCMAKE_C_FLAGS=-fPIC
- -DCMAKE_CXX_FLAGS=-fPIC
- -DCMAKE_EXE_LINKER_FLAGS=-pie
provides:
- bin/thrift1
test:
Expand Down