fix-up.ts not catching our new directory names #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this creates broken .pc and .cmake output. see: https://github.com/pkgxdev/pantry/actions/runs/7267412014/job/19801705304
mxcl
requested changes
Dec 20, 2023
Member
|
Sorry I should have thought of this. |
Member
|
A fixture would prevent this regressing |
jhheider
force-pushed
the
fix-fixup
branch
2 times, most recently
from
eecc82c to
c5281e3
Compare
Contributor
Author
good point: working new fixture: https://github.com/pkgxdev/brewkit/actions/runs/7277880130/job/19830875019 |
mxcl
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this creates broken .pc and .cmake output.
see: https://github.com/pkgxdev/pantry/actions/runs/7267412014/job/19801705304
there still seems to be 18-24 hour lag when a package rebuild is "seen" by pantry CI, even though the CDN is serving the right package, so this will take time to clear up. :/