Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a pull request open in the right panel or on the Pull requests page, opening it in the browser means going through the
…menu → "Open on GitHub". The panel already has shortcuts to copy the PR link (mod+shift+c) and number (mod+shift+k), but none to open it.Change
pullRequest.openOnHostkeybinding command, bound by default tomod+shift+owithwhen: "pullRequestPanelActive && !terminalFocus". It calls the sameshell.openExternal(url)as the menu item, and the menu item now shows the shortcut. It is rebindable in Settings as "Pull Request: Open in Browser".mod+shift+ois already a second default forchat.new, so the new binding only applies while a PR is the active right panel surface. The PR panel resolves its shortcuts withpullRequestPanelActive: true; nothing else sets that variable, somod+shift+ostill starts a new chat everywhere else.keybindings.jsonfiles already containchat.newonmod+shift+o. The server backfills new defaults before persisted rules, so that persisted rule would always win. The panel therefore resolves against only thepullRequest.*bindings (pullRequestPanelKeybindings), so its own shortcuts win while it is active. Without this, the shortcut only works on fresh installs.Scope and approval
This is a new shortcut, so it needs maintainer approval. Proposal: #33882. The PR stays a draft until the direction is approved, and I'm happy to change the default key or leave it unbound.
Verification
apps/web/src/keybindings.test.ts: the existing "older server bindings" case now also checks that, with a persisted config lacking the new command,mod+shift+oresolves topullRequest.openOnHostin the PR panel and tochat.newelsewhere. The panel assertion fails without thepullRequest.*filter.Ctrl+Shift+Ocalledwindow.open("https://github.com/pingdotgg/t3code/pull/28799")and did not create a chat.Ctrl+Shift+Ocreated a new draft thread as before.shell.openExternalbridge as the existing menu item) and the right panel in the chat view (samePullRequestDetailPanelcomponent and listener).vp run check:changedpasses.Made with Claude Opus 5.5 in Claude Code, running inside T3 Code.