[only21mil]

Problem

t3_environment_preferences_update told agents it works for a "full-access or default caller thread", and run_scheduled_task_now said it "Needs a full-access or default caller". Both tools sit behind McpToolAccess.writesEnvironment, whose check (assertFullAccess in apps/server/src/mcp/threadAccess.ts) needs both runtime mode full-access and interaction mode default. A thread in approval-required/default mode reads the text as allowed and gets capability_denied.

Change

Both descriptions now say "Full-access non-plan thread/client only." The access check and the tool schemas are unchanged. The new text is 5 bytes shorter, so agentContextBudget.json lowers mcpToolListJsonBytes from 48131 to 48126. The six other tools behind the same check state no access rule and are left alone. This PR does not change the check itself (#25481 asks for that).

Scope and approval

There is no prior issue. This is a small fix for an obvious bug: two tool descriptions contradict the check the tools enforce, and nothing else changes. The six other tools behind the same check (t3_project_create, t3_project_update, t3_project_delete, t3_project_clone, t3_environment_link, t3_environment_unlink) state no access rule in their descriptions, and this PR leaves them alone. #25481 asks to change the check itself for users who cannot use full access; this PR does not.

Verification

• vp run check:changed and the access, handler and budget suites pass.
• mcp-tool-use on main 52d621a6f1 and head 1ce3bdeeb4: agent gpt-6.1-sol (capture effort xhigh), shell gpt-6.1-terra, both through a CLIProxyAPI server on subscription quota (no per-token charge). The five cases that cover run_scheduled_task_now, 3 samples each:

main 52d621a6f1
- Pass: 100% of 15 samples.
head 1ce3bdeeb4 (Baseline = the main run)
- Pass: 100% of 15 samples.
| Group | Pass | Baseline | Delta |
| --- | --- | --- | --- |
| control-nightly-time-question | 100% of 3 | 100% | 0 pts |
| schedule-fresh-session-per-run | 100% of 3 | 100% | 0 pts |
| schedule-one-off-tomorrow | 100% of 3 | 100% | 0 pts |
| schedule-one-time-date | 100% of 3 | 100% | 0 pts |
| schedule-runs-job-first | 100% of 3 | 100% | 0 pts |

• One full run on the earlier head 3d385bf409 (168 non-device cases on Codex): 324 of 340 graded samples pass. On main d313b2aff3, the 9 cases that missed on the head pass 6 of 20 samples, against 6 of 22 on the head. Of the 30 head samples that loaded the new text, 29 pass. The miss (thread-send-fresh-context) also fails on main.

Real run on each revision: a test T3 server built from it, with the Codex CLI 0.167.1 (gpt-6-luna) as the agent. A client reads tools/list, then starts one thread per mode asking Codex to call both tools. In approval-required mode, Allow was pressed on each approval card (the client's approval response, sent over the WebSocket API). Below are the agent's calls to the two tools with the server's results, read back from each thread. On the candidate, the first full-access/default thread called neither tool, so that one thread was run again. Only the descriptions change.

Before (main 52d621a6f1):

tools/list from the test server (MCP client):
  run_scheduled_task_now:
    "Run one scheduled task now. Needs a full-access or default caller. Returns its thread, or null if not started. Success means started, not finished."
  t3_environment_preferences_update:
    "Update environment-wide preferences. Live full-access or default caller thread only. Omitted fields are unchanged; `customInstructions: ''` clears it."

Codex (gpt-6-luna) threads, each asked to call both tools (runtime mode / interaction mode):
  t3_environment_preferences_update  approval-required / default  (Allow pressed) -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  run_scheduled_task_now             approval-required / default  (Allow pressed) -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  t3_environment_preferences_update  full-access / plan           -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  run_scheduled_task_now             full-access / plan           -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  t3_environment_preferences_update  full-access / default        -> ok
  run_scheduled_task_now             full-access / default        -> invalid_request: The scheduled task was not found.

After (head 1ce3bdeeb4):

tools/list from the test server (MCP client):
  run_scheduled_task_now:
    "Run one scheduled task now. Full-access non-plan thread/client only. Returns its thread, or null if not started. Success means started, not finished."
  t3_environment_preferences_update:
    "Update environment-wide preferences. Full-access non-plan thread/client only. Omitted fields are unchanged; `customInstructions: ''` clears it."

Codex (gpt-6-luna) threads, each asked to call both tools (runtime mode / interaction mode):
  t3_environment_preferences_update  approval-required / default  (Allow pressed) -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  run_scheduled_task_now             approval-required / default  (Allow pressed) -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  t3_environment_preferences_update  full-access / plan           -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  run_scheduled_task_now             full-access / plan           -> capability_denied: Changing projects or environment settings needs a live full-access/default calling thread or a full-access client.
  t3_environment_preferences_update  full-access / default        -> ok
  run_scheduled_task_now             full-access / default        -> invalid_request: The scheduled task was not found.

Not checked

• Claude models in mcp-tool-use. That route bills ANTHROPIC_API_KEY per token, so it was not run.
• No eval case covers t3_environment_preferences_update, and none was added: no model failure from this text has been seen.

Prior PRs

• feat(server): every T3 MCP tool declares who may call it #16335 (@juliusmarminge) declared who may call each T3 MCP tool.
• feat(mcp): expose selected environment preferences #10560 and feat(mcp): expose scheduled task run-now #10562 (@juliusmarminge) exposed these two tools over MCP.

Generated with Claude Opus 5.5 and GPT-6.1 Terra and GPT-6.1 Sol in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Approved at e22876b

Macroscope's review found this PR approvable — Clarifies two MCP tool descriptions to match their existing full-access, non-plan gate and updates the tool-list size snapshot. Permissions, execution behavior, and product defaults remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: 1ce3bde

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• Resume reviews
• Trigger review

No actionable comments were generated in the recent review.

Walkthrough

Two MCP tool descriptions now specify full-access, non-plan thread/client eligibility. The configured MCP tool-list byte count changes from 48131 to 48126.

Changes: MCP Tool Description Updates

Layer / File(s)	Summary
Update tool descriptions and byte count apps/server/src/mcp/toolkits/environment/tools.ts, apps/server/src/mcp/toolkits/thread/tools.ts, apps/server/src/provider/agentContextBudget.json	The environment preferences and scheduled task run descriptions now specify a full-access, non-plan thread/client. The configured MCP tool-list byte count changes from 48131 to 48126.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related issues

• pingdotgg/t3code#25481: The PR clarifies the full-access requirement in the t3_environment_preferences_update description. It does not change the access gate or add an approval path.

Suggested reviewers: gabrielelpidio, t3dotgg, maria-rcks

Merge Risk: Minimal · up to 1ce3b

This updates two tool descriptions to match the existing full-access, non-plan access requirement. It changes no runtime behavior, so merge risk is minimal.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: correcting MCP tool descriptions to state the full-access requirement.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The pull request includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the access-description mismatch, the limited code changes, the absence of prior appr…

Full details: Description check

Explanation

The pull request includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the access-description mismatch, the limited code changes, the absence of prior approval, focused verification results, unrun checks, and agent usage.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 52d621a
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9aea106c-062f-41bd-9c25-9b489fc51df9

Commits

Reviewing files that changed from the base of the PR and between 573e04b and 1ce3bde.

Files selected for processing: 1

• apps/server/src/provider/agentContextBudget.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Merged current main without rebasing and resolved the context-budget conflict by preserving main's current values and applying this PR's five-byte tool-description reduction. The diff remains three insertions and three deletions across the original three files.

Blacksmith verification passed: 74 focused access/handler/budget tests and vp run check:changed github/main, including lint and affected typechecks. Two independent reviews approved 4240a067036e790db085931d72200ca17621b89b with no findings. Live-model evals remain unverified because this VM has neither an API key nor the eval proxy configured.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

Merged current main in 3d385bf to clear the conflict in agentContextBudget.json. It keeps main's values and measures mcpToolListJsonBytes again with AgentContextBudget.test.ts: 48217 on main, 48212 with the two shorter descriptions. The diff is still three lines in the same three files, and nothing was dropped. Main still has both old descriptions, and assertFullAccess still requires full-access and default.

check:changed, the access, handler and budget suites (75 tests), mcp-tool-use --context (descriptions 15048 → 15043 chars) and --dry-run for the five run_scheduled_task_now cases pass. The paid eval run was not done. The body now has the updated numbers and a before and after capture of the advertised descriptions and the access check.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

@maria-rcks we ran the mcp-tool-use evals for this text on main (d313b2aff3) and this head (3d385bf409), agent gpt-6.1-sol with gpt-6.1-terra as the shell, through a CLIProxyAPI server on subscription quota, so no per-token charges. The five cases that cover run_scheduled_task_now passed on both, and the README's full run on the head passed 324 of 340 graded samples across 168 cases; the 9 cases that missed there passed 6 of 20 on main against 6 of 22 on the head, and 29 of the 30 head samples that loaded the new text passed (the miss also fails on main). No case covers t3_environment_preferences_update, and Claude models stay unrun because their eval route bills a per-token key.

main d313b2aff3  mcp-tool-use, 5 covering cases x 3 samples: Pass 100% of 15
head 3d385bf409  mcp-tool-use, 5 covering cases x 3 samples: Pass 100% of 15 (0 pts change on every case)

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

@maria-rcks Your report ran on 4240a06703; the head is now 1ce3bdeeb4. Every commit since then is a merge of main, and the diff against main is still the same two description strings. Only mcpToolListJsonBytes moved with main: it is now 48126, main's 48131 minus the same 5 bytes.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

Closing this: it is not a bug fix, and this repository now takes only bug fixes from outside contributors. The branch stays on my fork if it is useful.