Repository navigation
fix(server): device_open finds a booted AVD by name and says when the device list failed - #30289
juliusmarminge wants to merge 10 commits into
Effect Service Conventions: 1 violation
apps/server/src/mcp/toolkits/device/handlers.ts:158–167: New device-resolution policy belongs inDeviceService, not the MCP handler. Posted an inline comment requesting the move and structured error translation.
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 2 changed files (no prior completed review)
🔍 Agent activity — 4 tool calls
1. browse_code — apps/server/src/mcp/toolkits/device/handlers.ts
💭 Clarifying placement needs I'm aiming to clarify the placement process. It seems like I need to move the domain logic to the existing service and address any typed errors within the mapping. Right now, I notice some ambiguity, especially with cross-file elements. It's essential to ensure everything is sufficiently clear for the user. I want to remove any confusion, so I'll need to examine the details more closely and make necessary adjustments.
2. modify_pr — Submitted review with 1 inline comment
3. browse_code — apps/server/src/device/DeviceService.ts
4. browse_code — apps/server/src/mcp/toolkits/device/handlers.ts
Agent Credits: 6 credits
Token usage: 15 uncached input · 60,273 cache-read input · 16,384 cache-write input · 420 output
Agent Credits may also include non-token charges from external tools such as web research.