Skip to content

fix(server): device_open finds a booted AVD by name and says when the device list failed - #30289

Open
juliusmarminge wants to merge 10 commits into
mainfrom
fix/issue-30273
Open

juliusmarminge wants to merge 10 commits into
mainfrom
fix/issue-30273

Merge remote-tracking branch 'origin/main' into fix/issue-30273

984d245
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 3, 2026 in 2m 23s

Approved

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Device opening now recognizes a running Android emulator by its AVD name and explains failed device listings. Existing host-selection, ambiguity, and access safeguards remain in place, keeping the change narrowly scoped.

Additional Thinking

Your Custom Policy

Default approvability criteria apply. Neither product defaults nor diagnostic-suppression directives change, so neither additional human-review condition is triggered.

Code

Device lookup now accepts an explicitly supplied Android AVD name for a uniquely running emulator when no scoped ID matches. Exact IDs retain priority, host ambiguity remains rejected, and duplicate emulators on one host are not guessed. device_open reports failed device listings rather than misleading missing-device or other-host errors. Existing access and readiness gates still precede opening.

Review Context

The author is a repository admin and ping-devs member; no separate ownership requirement was supplied. No unresolved review comments or correctness findings were supplied, and no blocking-severity configuration or check results were provided. The supplied production diff and surrounding callers establish the limited reach.

Verdict

This is a bounded improvement to explicit emulator targeting and failure reporting. Host selection, ambiguity rejection, and device-access gates remain in place; automatic device selection and product defaults are unchanged. No obvious material consequence requires human judgment.

Notes:
No code owners found in target merge base 115739c


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.