Repository navigation
fix(desktop): Windows updates no longer quit into the installer without disk space - #27526
juliusmarminge wants to merge 13 commits into
Test Signal: 2 findings
apps/desktop/src/updates/DesktopUpdates.test.ts: Fold the threshold test into the retry case.apps/desktop/src/app/DesktopStartupRecovery.test.ts: Fold the install-error assertion into the retained-download case.
Details
Warning
- A front-matter
includereviewed "apps/desktop/src/updates/DesktopDiskSpace.test.ts", which your.macroscopeignore file excludes (pattern**/*.test.ts). - A front-matter
includereviewed "apps/desktop/src/updates/DesktopUpdates.test.ts", which your.macroscopeignore file excludes (pattern**/*.test.ts). - A front-matter
includereviewed "apps/desktop/src/app/DesktopStartupRecovery.test.ts", which your.macroscopeignore file excludes (pattern**/*.test.ts).
Note
Your check run agent prompt is: .macroscope/check-run-agents/test-signal.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 3 changed files (no prior completed review)
🔍 Agent activity — 9 tool calls
1. browse_code — docs/internals/testing.md
💭 Inspecting existing tests I need to take a closer look at the current tests to ensure they fit what I'm looking for. I wonder if they'll meet the criteria or highlight areas that might need adjustments. It's important to analyze and evaluate each test thoroughly, so I can identify any issues or improvements. Let's figure out how to approach this task effectively! Prioritizing a detailed inspection will definitely help steer me in the right direction.
2. browse_code — apps/desktop/src/updates/DesktopUpdates.test.ts
3. browse_code — apps/desktop/src/app/DesktopStartupRecovery.test.ts
4. modify_pr — Submitted review with 2 inline comments
5. browse_code — apps/desktop/src/updates/DesktopDiskSpace.test.ts
6. modify_pr — Test Signal review: two tests can be folded into existing cases, as noted inline.
7. modify_pr — Minimized comment (off-topic)
8. browse_code — docs/internals/testing.md
9. modify_pr — not performed: the agent's request was refused before it ran
Agent Credits: 5 credits
Token usage: 30 uncached input · 190,129 cache-read input · 24,053 cache-write input · 975 output
Agent Credits may also include non-token charges from external tools such as web research.