fix(desktop): Windows updates no longer quit into the installer without disk space - #27526

Eligibility
The change keeps Windows updates from quitting into the installer when measured disk space is insufficient and surfaces a retryable error. It also adds a file-level static-analysis suppression in DesktopDiskSpace.ts that requires human review.

Additional Thinking

Your Custom Policy

Default criteria apply, with mandatory human review for product-default changes and new diagnostic suppressions. DesktopDiskSpace.ts adds the file-level directive @effect-diagnostics nodeBuiltinImport:off, directly triggering the diagnostic-suppression requirement. No product-setting default change is evident in the supplied diff.

Code

Adds a Windows update-install disk-space preflight using read-only filesystem measurements and a 128 MiB margin. Insufficient space leaves the app running and reports an install error in recovery and settings UI; unavailable measurements log warnings and allow installation. The check runs before quitting or stopping backends. Three ignored files were excluded from assessment.

Review Context

The author is a repository admin and ping-devs member; no explicit ownership requirement was supplied. The supplied thread check reports one resolved thread and no unresolved comments. No correctness findings, blocking-severity configuration, or CI results were supplied.

Verdict

Human review is explicitly required for the new file-level diagnostic suppression in DesktopDiskSpace.ts. A human must decide whether bypassing the nodeBuiltinImport diagnostic for native filesystem access is acceptable; the stated filesystem rationale does not exempt it from that requirement.

Notes:
No code owners found in target merge base 32ecd71

Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.