Skip to content

update submodules#1586

Merged
damianloew merged 1 commit into
masterfrom
adamdebek/submodules_update
Mar 23, 2026
Merged

update submodules#1586
damianloew merged 1 commit into
masterfrom
adamdebek/submodules_update

Conversation

@adamdebek

Copy link
Copy Markdown
Contributor
  • phoenix-rtos-build 488bdb9...bbe57b6 (3):

    port_manager: fix override by if: false when sourcing many port.yamls
    port.subr: decrease wget output noise by setting "dot:mega" progress
    port.subr: decrease wget tries/timeout and make it configurable

  • phoenix-rtos-ports 53a9a3f...1b28be3 (1):

    lsb_vsx: fix building exec tests

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

* phoenix-rtos-build 488bdb9...bbe57b6 (3):
  > port_manager: fix override by `if: false` when sourcing many port.yamls
  > port.subr: decrease wget output noise by setting "dot:mega" progress
  > port.subr: decrease wget tries/timeout and make it configurable

* phoenix-rtos-ports 53a9a3f...1b28be3 (1):
  > lsb_vsx: fix building exec tests
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on synchronizing the project's dependencies by updating the phoenix-rtos-build and phoenix-rtos-ports submodules. These updates integrate recent bug fixes and minor enhancements from their respective upstream repositories, ensuring the main project benefits from the latest stable versions of these components.

Highlights

  • phoenix-rtos-build submodule update: Updated the phoenix-rtos-build submodule to commit bbe57b6, incorporating fixes for port_manager override issues, reduced wget output noise, and configurable wget tries/timeout.
  • phoenix-rtos-ports submodule update: Updated the phoenix-rtos-ports submodule to commit 1b28be3, which includes a fix for building exec tests in lsb_vsx.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the phoenix-rtos-build and phoenix-rtos-ports submodules to their latest commits. The changes are limited to updating these submodule pointers. The modifications appear to be in order, and I have no specific feedback on the submodule hash updates themselves.

@github-actions

Copy link
Copy Markdown

Unit Test Results

9 553 tests  ±0   8 961 ✅ ±0   53m 19s ⏱️ - 1m 49s
  591 suites ±0     592 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 73403cb. ± Comparison against base commit 1c0b759.

@adamdebek adamdebek requested a review from a team March 23, 2026 16:14
@damianloew damianloew merged commit 38f50e0 into master Mar 23, 2026
43 checks passed
@damianloew damianloew deleted the adamdebek/submodules_update branch March 23, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants