Skip to content

build: add noexecstack#1160

Merged
badochov merged 2 commits intomasterfrom
badochov/noexecstack
Sep 23, 2024
Merged

build: add noexecstack#1160
badochov merged 2 commits intomasterfrom
badochov/noexecstack

Conversation

@badochov
Copy link
Contributor

@badochov badochov commented Sep 9, 2024 •
edited
Loading

Submodule update

  • phoenix-rtos-build 52927a8...97fb495 (3):
    < toolchain: update multilib configuration for SPARC
    < toolchain: add patch with armv7-r/v8-r multilib config
    < toolchain: add PIC flags to armv7-r/v8-r in libstdcpp

JIRA: RTOS-909

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov mentioned this pull request Sep 9, 2024
Merged
14 tasks
@github-actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 48s ⏱️ +23s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8ca6c58. ± Comparison against base commit d635351.

♻️ This comment has been updated with latest results.

@badochov badochov marked this pull request as ready for review September 9, 2024 15:45
@badochov badochov requested a review from agkaminski September 9, 2024 15:45
@badochov badochov mentioned this pull request Sep 10, 2024
Merged
14 tasks
@badochov badochov force-pushed the badochov/noexecstack branch from 42e800a to e1c0350 Compare September 11, 2024 09:49
@badochov badochov changed the title feat(build): add noexecstack build: add noexecstack Sep 11, 2024
@badochov badochov force-pushed the badochov/noexecstack branch from e1c0350 to ea57965 Compare September 17, 2024 13:58
@nalajcie
Copy link
Member

nalajcie commented Sep 20, 2024

If I remember correctly - this problems originates from the .o generated from .S not having necessary .note section.

This can be fixed in the code (in every .S file):

/* GNU ld from binutils 2.39+ introduce warning about deprecation of defaulting to executable stack if .note.GNU-stack not 
 * Creating this section causes that stack is non-executable explicitly and suppresses warning                                                                                               
 */                                                                                                                                                                                          
.section  .note.GNU-stack, "", %progbits

Just showing alternative way, right now we might globally disable executable stack by explicit ld param.

agkaminski
agkaminski previously approved these changes Sep 23, 2024
View reviewed changes
@agkaminski agkaminski dismissed their stale review September 23, 2024 11:28

Not ready for merge

@agkaminski
Copy link
Member

agkaminski commented Sep 23, 2024

LGTM

@badochov badochov force-pushed the badochov/noexecstack branch from ea57965 to 8da2b5a Compare September 23, 2024 11:37
@badochov badochov force-pushed the badochov/noexecstack branch from 8da2b5a to 0eb2088 Compare September 23, 2024 11:52
Hubert Badocha added 2 commits September 23, 2024 13:53
build: adapt scripts to noexecstack
bc34e59 
JIRA: RTOS-999
submodule update
8ca6c58 
* phoenix-rtos-build 52927a8...97fb495 (3):
  < toolchain: update multilib configuration for SPARC
  < toolchain: add patch with armv7-r/v8-r multilib config
  < toolchain: add PIC flags to armv7-r/v8-r in libstdcpp
@badochov badochov force-pushed the badochov/noexecstack branch from 0eb2088 to 8ca6c58 Compare September 23, 2024 11:53
@badochov badochov merged commit 222b2f4 into master Sep 23, 2024
@badochov badochov deleted the badochov/noexecstack branch September 23, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badochov @nalajcie @agkaminski