Skip to content

build: add noexecstack flag#201

Merged
agkaminski merged 1 commit intomasterfrom
badochov/noexecstack
Sep 23, 2024
Merged

build: add noexecstack flag#201
agkaminski merged 1 commit intomasterfrom
badochov/noexecstack

Conversation

@badochov
Copy link

@badochov badochov commented Sep 9, 2024 •
edited
Loading

Newer linker version(>-2.39) issues a warning if stack is executable. Setting -z stack-size without -z noexecstack can cause this issue. On Phoenix stack is currently never executable.

JIRA: RTOS-909

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov force-pushed the badochov/noexecstack branch from ecb827d to fa3f986 Compare September 9, 2024 15:19
@badochov badochov mentioned this pull request Sep 9, 2024
Merged
14 tasks
@badochov badochov marked this pull request as ready for review September 10, 2024 10:01
@badochov badochov requested a review from agkaminski September 10, 2024 10:06
@badochov badochov force-pushed the badochov/noexecstack branch from fa3f986 to 993bd0d Compare September 11, 2024 09:49
@badochov badochov changed the title feat(build): add noexecstack flag build: add noexecstack flag Sep 11, 2024
@badochov badochov mentioned this pull request Sep 11, 2024
Closed
14 tasks
build: add noexecstack flag
74f5709 
Newer linker versions (>= 2.39) issues a warning if stack is executable. Setting
-z stack-size without -z noexecstack can cause this issue. On Phoenix
stack is currently never executable.

JIRA: RTOS-909
@badochov badochov force-pushed the badochov/noexecstack branch from 993bd0d to 74f5709 Compare September 17, 2024 12:15
@badochov
Copy link
Author

badochov commented Sep 23, 2024

@agkaminski can you force merge it, I don't have the required permissions 🙏

@agkaminski
Copy link
Member

agkaminski commented Sep 23, 2024

💪

@agkaminski agkaminski merged commit f335a5c into master Sep 23, 2024
@agkaminski agkaminski deleted the badochov/noexecstack branch September 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@badochov @agkaminski