Conversation
95d1b7e to
c53614d
Compare
865ebe4 to
d356b5a
Compare
Darchiv
left a comment
There was a problem hiding this comment.
I would rather fix these issues in ports by local patches than disable warnings.
lighttpd is slightly bugger issue, because we have an upgrade PR to 1.4.77 pending, so patching lighttpd before PR is merged may be wasteful
mbedtls/build.sh
Outdated
| # Build mbedtls without tests | ||
| (cd "${PREFIX_PORT_BUILD}/${MBEDTLS}" && make install no_test DESTDIR="$PREFIX_MBEDTLS_DESTDIR") | ||
| # FIXME: -Wno-error=incompatible-pointer-types is needed as mbedtls doesn't recognise phoenix definition of socklen_t | ||
| (cd "${PREFIX_PORT_BUILD}/${MBEDTLS}" && make install no_test DESTDIR="$PREFIX_MBEDTLS_DESTDIR" CFLAGS="-Wno-error=incompatible-pointer-types") |
There was a problem hiding this comment.
mbedtls (2.28.0) does the following:
#if defined(__socklen_t_defined) || defined(_SOCKLEN_T) || \
defined(_SOCKLEN_T_DECLARED) || defined(__DEFINED_socklen_t) || \
defined(socklen_t) || (defined(_POSIX_VERSION) && _POSIX_VERSION >= 200112L)
socklen_t n = (socklen_t) sizeof( client_addr );
socklen_t type_len = (socklen_t) sizeof( type );
#else
int n = (int) sizeof( client_addr );
int type_len = (int) sizeof( type );
#endifApparently, we don't define any such macros, commonly found in glibc, musl, FreeBSD's libc, etc. (We only define SOCKLEN_T_DEFINED in lwip.) We don't even have _POSIX_VERSION defined in unistd.h. I think defining _POSIX_VERSION is the way to go.
There was a problem hiding this comment.
Finally, we opted for _SOCKLEN_T phoenix-rtos/libphoenix#408 Defines which shadow existing types cause LSP/IDEs to only show macro expansion instead of treating it as a type
This changes do not disable warnings but rather mark warnings as not errors. There are more warnings in the ports. I do not think that patching all of them is feasible. |
d356b5a to
3d7cd5e
Compare
|
phoenix-rtos/libphoenix#408 is merged now so you can omit the mbedtls patch |
JIRA: RTOS-927
JIRA: RTOS-927
3d7cd5e to
0b4af77
Compare
JIRA: RTOS-927
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment