Skip to content

socktypes.h: define _SOCKLEN_T#408

Merged
badochov merged 1 commit intomasterfrom
badochov/libphoenix-typedefines
Mar 25, 2025
Merged

socktypes.h: define _SOCKLEN_T#408
badochov merged 1 commit intomasterfrom
badochov/libphoenix-typedefines

Conversation

@badochov
Copy link
Contributor

Some external program eg mbedtls check for those defines to checks if a type is available.

JIRA: RTOS-1027

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@badochov badochov requested a review from Darchiv March 18, 2025 13:21
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from fb628d6 to 21a0bef Compare March 18, 2025 13:28
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 21a0bef to 8e21cb8 Compare March 18, 2025 13:29
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 8e21cb8 to 6f2e994 Compare March 18, 2025 13:33
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 6f2e994 to 7620e96 Compare March 18, 2025 13:33
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 7620e96 to 96beae2 Compare March 18, 2025 13:35
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 96beae2 to 8aad691 Compare March 18, 2025 13:36
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 8aad691 to a09797a Compare March 18, 2025 13:43
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from a09797a to f50f5d6 Compare March 18, 2025 13:44
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from f50f5d6 to 8486a81 Compare March 18, 2025 13:45
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Unit Test Results

7 958 tests   7 434 ✅  40m 16s ⏱️
  470 suites    524 💤
    1 files        0 ❌

Results for commit a6dab58.

♻️ This comment has been updated with latest results.

Add define to inform mbedtls socklen is defined.

JIRA: RTOS-1027
@badochov badochov force-pushed the badochov/libphoenix-typedefines branch from 8486a81 to a6dab58 Compare March 18, 2025 16:52
@badochov
Copy link
Contributor Author

@Darchiv I changed this PR to only handle the SOCKLEN_T special case

Copy link
Member

@Darchiv Darchiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update PRs title

@badochov badochov changed the title types: add #defines to typedefs socktypes.h: define _SOCKLEN_T Mar 25, 2025
@badochov badochov merged commit 307f01f into master Mar 25, 2025
37 checks passed
@badochov badochov deleted the badochov/libphoenix-typedefines branch March 25, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants