fix: correct urls by merlinpaypal · Pull Request #32 · paypal/paypal-messages-android

merlinpaypal · 2024-04-03T19:54:39Z

Description

Fixes URL overloading such that "Apply Now" and "Terms and Conditions" links works
Adds default value for clientID using string locals to Jetpack
Fixes environment issue where it was being overridden by getConfig
Fixes script issue for pre-commit verification

Testing instructions

Run a demo app
Open each view and click its various external links
Each link should open a page successfully

github-actions · 2024-04-03T19:56:26Z

Code Coverage

Total Project Coverage	98.57%	✅

## 1.0.0-develop.1 (2024-04-11) ### Features * accessibility ([#31](#31)) ([20644c8](20644c8)) * add instance_id ([#4](#4)) ([d72ccee](d72ccee)) * base of GitHub workflows ([#5](#5)) ([c32defe](c32defe)) * create a snapshot workflow ([#22](#22)) ([5bc02da](5bc02da)) * debounce config updates ([#24](#24)) ([7d0a043](7d0a043)) * jetpack compose demo ([#10](#10)) ([a47065e](a47065e)) * modal updates ([#28](#28)) ([101ade5](101ade5)) * package pre-release ([#14](#14)) ([d63f834](d63f834)) * page type ([#26](#26)) ([c79e439](c79e439)) * session id and device id ([#30](#30)) ([a7208eb](a7208eb)) * update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb)) * use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c)) * xml demo ([#6](#6)) ([4b33504](4b33504)) ### Bug Fixes * correct urls ([#32](#32)) ([f72ffda](f72ffda)) * remove kotlinter ([1550f44](1550f44)) * update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1)) ### Code Refactoring * adjust logo alignment ([#23](#23)) ([6347be3](6347be3)) * clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff)) * prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032)) * prevent empty values ([#29](#29)) ([b7b746f](b7b746f)) * radio offer type and other things ([#11](#11)) ([960a48a](960a48a)) * route changes ([#13](#13)) ([6434e30](6434e30)) * use dot getters and setters ([#9](#9)) ([84316bb](84316bb)) ### Continuous Integration * functional tests ([#16](#16)) ([51d9ec6](51d9ec6)) * lint and test ([#8](#8)) ([8a22f0b](8a22f0b)) * update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))

github-actions · 2024-04-11T13:57:06Z

🎉 This PR is included in version 1.0.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## 1.0.0 (2024-05-14) ### Features * accessibility ([#31](#31)) ([20644c8](20644c8)) * add instance_id ([#4](#4)) ([d72ccee](d72ccee)) * base of GitHub workflows ([#5](#5)) ([c32defe](c32defe)) * create a snapshot workflow ([#22](#22)) ([5bc02da](5bc02da)) * debounce config updates ([#24](#24)) ([7d0a043](7d0a043)) * jetpack compose demo ([#10](#10)) ([a47065e](a47065e)) * modal updates ([#28](#28)) ([101ade5](101ade5)) * package pre-release ([#14](#14)) ([d63f834](d63f834)) * page type ([#26](#26)) ([c79e439](c79e439)) * remove session id and device id ([#35](#35)) ([20367ca](20367ca)) * session id and device id ([#30](#30)) ([a7208eb](a7208eb)) * update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb)) * use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c)) * xml demo ([#6](#6)) ([4b33504](4b33504)) ### Bug Fixes * allow messages to be updated any time ([#34](#34)) ([ef69ce9](ef69ce9)) * correct urls ([#32](#32)) ([f72ffda](f72ffda)) * general analytics fixes ([#36](#36)) ([ff2ac5a](ff2ac5a)) * modal analytics fixes ([#37](#37)) ([c95246f](c95246f)) * remove kotlinter ([1550f44](1550f44)) * update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1)) * update tracking format ([#33](#33)) ([dc8dd61](dc8dd61)) ### Code Refactoring * adjust logo alignment ([#23](#23)) ([6347be3](6347be3)) * clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff)) * prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032)) * prevent empty values ([#29](#29)) ([b7b746f](b7b746f)) * radio offer type and other things ([#11](#11)) ([960a48a](960a48a)) * route changes ([#13](#13)) ([6434e30](6434e30)) * use dot getters and setters ([#9](#9)) ([84316bb](84316bb)) ### Continuous Integration * change os ([#38](#38)) ([f7da086](f7da086)) * functional tests ([#16](#16)) ([51d9ec6](51d9ec6)) * lint and test ([#8](#8)) ([8a22f0b](8a22f0b)) * update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))

github-actions · 2024-05-14T23:31:54Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

merlinstardust added 2 commits April 3, 2024 15:47

fix: correct url loading

bc876cc

fix: correct environment issues

698156c

merlinpaypal requested a review from grablack April 3, 2024 19:54

merlinstardust added 3 commits April 3, 2024 16:04

fix: change xml demo to use blank buyer country as default

6d6a9eb

fix: remove empty buyerCountry and fix offer type

d16d7b7

Fix tests

2ec6a59

grablack approved these changes Apr 5, 2024

View reviewed changes

Fix test

291ec63

merlinpaypal merged commit f72ffda into develop Apr 8, 2024

merlinpaypal deleted the fix/correct-urls branch April 8, 2024 14:08

github-actions bot added the released on @develop label Apr 11, 2024

github-actions bot added the released label May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct urls#32

fix: correct urls#32
merlinpaypal merged 6 commits intodevelopfrom
fix/correct-urls

merlinpaypal commented Apr 3, 2024

Uh oh!

github-actions bot commented Apr 3, 2024

Uh oh!

github-actions bot commented Apr 11, 2024

Uh oh!

github-actions bot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

merlinpaypal commented Apr 3, 2024

Description

Testing instructions

Uh oh!

github-actions bot commented Apr 3, 2024

Code Coverage

Uh oh!

github-actions bot commented Apr 11, 2024

Uh oh!

github-actions bot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants