Skip to content

feat: page type#26

Merged
merlinpaypal merged 3 commits intodevelopfrom
feat/page-type
Mar 2, 2024
Merged

feat: page type#26
merlinpaypal merged 3 commits intodevelopfrom
feat/page-type

Conversation

@merlinpaypal
Copy link
Contributor

@merlinpaypal merlinpaypal commented Feb 26, 2024

Description

  • Replaced placement with pageType
  • Made a PageType enum
  • Updated pre-commit script to only run for files inside library/ or demo/

Testing instructions

  1. Set a pageType in the demo
  2. Run the demo
  3. Check the logging payload logs to see pageType instead of placement

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Code Coverage

File Coverage [100.00%] ✅
library/src/main/java/com/paypal/messages/config/PayPalMessagePageType.kt 100.00% ✅
library/src/main/java/com/paypal/messages/config/message/PayPalMessageData.kt 100.00% ✅
library/src/main/java/com/paypal/messages/logger/TrackingComponent.kt 100.00% ✅
Total Project Coverage 98.57% ✅

@merlinpaypal merlinpaypal merged commit c79e439 into develop Mar 2, 2024
@merlinpaypal merlinpaypal deleted the feat/page-type branch March 2, 2024 12:51
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
@semantic-release-bot
chore(release): 1.0.0-minSdkMatch.1 [skip ci]
8ad668d 
## 1.0.0-minSdkMatch.1 (2024-04-03)

### Features

* add instance_id  ([#4](#4)) ([d72ccee](d72ccee))
* base of GitHub workflows ([#5](#5)) ([c32defe](c32defe))
* debounce config updates ([#24](#24)) ([7d0a043](7d0a043))
* jetpack compose demo ([#10](#10)) ([a47065e](a47065e))
* package pre-release ([#14](#14)) ([d63f834](d63f834))
* page type ([#26](#26)) ([c79e439](c79e439))
* update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb))
* use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c))
* xml demo ([#6](#6)) ([4b33504](4b33504))

### Bug Fixes

* remove kotlinter ([1550f44](1550f44))
* update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1))

### Code Refactoring

* adjust logo alignment ([#23](#23)) ([6347be3](6347be3))
* clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff))
* prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032))
* radio offer type and other things ([#11](#11)) ([960a48a](960a48a))
* route changes ([#13](#13)) ([6434e30](6434e30))
* use dot getters and setters ([#9](#9)) ([84316bb](84316bb))

### Continuous Integration

* functional tests ([#16](#16)) ([51d9ec6](51d9ec6))
* lint and test ([#8](#8)) ([8a22f0b](8a22f0b))
* update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 1.0.0-minSdkMatch.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@semantic-release-bot
chore(release): 1.0.0-develop.1 [skip ci]
5265b5d 
## 1.0.0-develop.1 (2024-04-11)

### Features

* accessibility ([#31](#31)) ([20644c8](20644c8))
* add instance_id  ([#4](#4)) ([d72ccee](d72ccee))
* base of GitHub workflows ([#5](#5)) ([c32defe](c32defe))
* create a snapshot workflow ([#22](#22)) ([5bc02da](5bc02da))
* debounce config updates ([#24](#24)) ([7d0a043](7d0a043))
* jetpack compose demo ([#10](#10)) ([a47065e](a47065e))
* modal updates ([#28](#28)) ([101ade5](101ade5))
* package pre-release ([#14](#14)) ([d63f834](d63f834))
* page type ([#26](#26)) ([c79e439](c79e439))
* session id and device id ([#30](#30)) ([a7208eb](a7208eb))
* update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb))
* use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c))
* xml demo ([#6](#6)) ([4b33504](4b33504))

### Bug Fixes

* correct urls ([#32](#32)) ([f72ffda](f72ffda))
* remove kotlinter ([1550f44](1550f44))
* update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1))

### Code Refactoring

* adjust logo alignment ([#23](#23)) ([6347be3](6347be3))
* clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff))
* prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032))
* prevent empty values ([#29](#29)) ([b7b746f](b7b746f))
* radio offer type and other things ([#11](#11)) ([960a48a](960a48a))
* route changes ([#13](#13)) ([6434e30](6434e30))
* use dot getters and setters ([#9](#9)) ([84316bb](84316bb))

### Continuous Integration

* functional tests ([#16](#16)) ([51d9ec6](51d9ec6))
* lint and test ([#8](#8)) ([8a22f0b](8a22f0b))
* update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024

🎉 This PR is included in version 1.0.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request May 14, 2024
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
d9b99f9 
## 1.0.0 (2024-05-14)

### Features

* accessibility ([#31](#31)) ([20644c8](20644c8))
* add instance_id  ([#4](#4)) ([d72ccee](d72ccee))
* base of GitHub workflows ([#5](#5)) ([c32defe](c32defe))
* create a snapshot workflow ([#22](#22)) ([5bc02da](5bc02da))
* debounce config updates ([#24](#24)) ([7d0a043](7d0a043))
* jetpack compose demo ([#10](#10)) ([a47065e](a47065e))
* modal updates ([#28](#28)) ([101ade5](101ade5))
* package pre-release ([#14](#14)) ([d63f834](d63f834))
* page type ([#26](#26)) ([c79e439](c79e439))
* remove session id and device id ([#35](#35)) ([20367ca](20367ca))
* session id and device id ([#30](#30)) ([a7208eb](a7208eb))
* update message view to use its own instance id ([#20](#20)) ([9efb3bb](9efb3bb))
* use nested coroutine to prevent blocking ([#19](#19)) ([b06039c](b06039c))
* xml demo ([#6](#6)) ([4b33504](4b33504))

### Bug Fixes

* allow messages to be updated any time ([#34](#34)) ([ef69ce9](ef69ce9))
* correct urls ([#32](#32)) ([f72ffda](f72ffda))
* general analytics fixes ([#36](#36)) ([ff2ac5a](ff2ac5a))
* modal analytics fixes ([#37](#37)) ([c95246f](c95246f))
* remove kotlinter ([1550f44](1550f44))
* update shared data ([#7](#7)) ([2fa1ea1](2fa1ea1))
* update tracking format ([#33](#33)) ([dc8dd61](dc8dd61))

### Code Refactoring

* adjust logo alignment ([#23](#23)) ([6347be3](6347be3))
* clone to prevent shallow copy ([#25](#25)) ([acfc3ff](acfc3ff))
* prevent destroying modal on close ([#3](#3)) ([ae7e032](ae7e032))
* prevent empty values ([#29](#29)) ([b7b746f](b7b746f))
* radio offer type and other things ([#11](#11)) ([960a48a](960a48a))
* route changes ([#13](#13)) ([6434e30](6434e30))
* use dot getters and setters ([#9](#9)) ([84316bb](84316bb))

### Continuous Integration

* change os ([#38](#38)) ([f7da086](f7da086))
* functional tests ([#16](#16)) ([51d9ec6](51d9ec6))
* lint and test ([#8](#8)) ([8a22f0b](8a22f0b))
* update semantic release ([#21](#21)) ([a9a3fb8](a9a3fb8))
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

grablack pushed a commit to grablack/paypal-messages-android that referenced this pull request Sep 4, 2025
@semantic-release-bot
chore(release): 1.0.0-develop.1 [skip ci]
fe374ac 
## 1.0.0-develop.1 (2024-04-11)

### Features

* accessibility ([#31](paypal/paypal-messages-android#31)) ([c44a39d](paypal/paypal-messages-android@c44a39d))
* add instance_id  ([#4](paypal/paypal-messages-android#4)) ([4a68644](paypal/paypal-messages-android@4a68644))
* base of GitHub workflows ([#5](paypal/paypal-messages-android#5)) ([be38640](paypal/paypal-messages-android@be38640))
* create a snapshot workflow ([#22](paypal/paypal-messages-android#22)) ([5c4c216](paypal/paypal-messages-android@5c4c216))
* debounce config updates ([#24](paypal/paypal-messages-android#24)) ([d3c79d6](paypal/paypal-messages-android@d3c79d6))
* jetpack compose demo ([#10](paypal/paypal-messages-android#10)) ([c059bca](paypal/paypal-messages-android@c059bca))
* modal updates ([#28](paypal/paypal-messages-android#28)) ([50dac7d](paypal/paypal-messages-android@50dac7d))
* package pre-release ([#14](paypal/paypal-messages-android#14)) ([0189e9e](paypal/paypal-messages-android@0189e9e))
* page type ([#26](paypal/paypal-messages-android#26)) ([cec9ca8](paypal/paypal-messages-android@cec9ca8))
* session id and device id ([#30](paypal/paypal-messages-android#30)) ([3d24ab1](paypal/paypal-messages-android@3d24ab1))
* update message view to use its own instance id ([#20](paypal/paypal-messages-android#20)) ([c4ab485](paypal/paypal-messages-android@c4ab485))
* use nested coroutine to prevent blocking ([#19](paypal/paypal-messages-android#19)) ([477305d](paypal/paypal-messages-android@477305d))
* xml demo ([#6](paypal/paypal-messages-android#6)) ([7143b6f](paypal/paypal-messages-android@7143b6f))

### Bug Fixes

* correct urls ([#32](paypal/paypal-messages-android#32)) ([adaa98c](paypal/paypal-messages-android@adaa98c))
* remove kotlinter ([8b5bcf1](paypal/paypal-messages-android@8b5bcf1))
* update shared data ([#7](paypal/paypal-messages-android#7)) ([e5c61f5](paypal/paypal-messages-android@e5c61f5))

### Code Refactoring

* adjust logo alignment ([#23](paypal/paypal-messages-android#23)) ([b012669](paypal/paypal-messages-android@b012669))
* clone to prevent shallow copy ([#25](paypal/paypal-messages-android#25)) ([3e2969f](paypal/paypal-messages-android@3e2969f))
* prevent destroying modal on close ([#3](paypal/paypal-messages-android#3)) ([352756d](paypal/paypal-messages-android@352756d))
* prevent empty values ([#29](paypal/paypal-messages-android#29)) ([4c47cac](paypal/paypal-messages-android@4c47cac))
* radio offer type and other things ([#11](paypal/paypal-messages-android#11)) ([283e2ae](paypal/paypal-messages-android@283e2ae))
* route changes ([#13](paypal/paypal-messages-android#13)) ([52e3dfc](paypal/paypal-messages-android@52e3dfc))
* use dot getters and setters ([#9](paypal/paypal-messages-android#9)) ([11007c2](paypal/paypal-messages-android@11007c2))

### Continuous Integration

* functional tests ([#16](paypal/paypal-messages-android#16)) ([4f46241](paypal/paypal-messages-android@4f46241))
* lint and test ([#8](paypal/paypal-messages-android#8)) ([51a1364](paypal/paypal-messages-android@51a1364))
* update semantic release ([#21](paypal/paypal-messages-android#21)) ([ec247dd](paypal/paypal-messages-android@ec247dd))
grablack pushed a commit to grablack/paypal-messages-android that referenced this pull request Sep 4, 2025
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
3d15ce6 
## 1.0.0 (2024-05-14)

### Features

* accessibility ([#31](paypal/paypal-messages-android#31)) ([c44a39d](paypal/paypal-messages-android@c44a39d))
* add instance_id  ([#4](paypal/paypal-messages-android#4)) ([4a68644](paypal/paypal-messages-android@4a68644))
* base of GitHub workflows ([#5](paypal/paypal-messages-android#5)) ([be38640](paypal/paypal-messages-android@be38640))
* create a snapshot workflow ([#22](paypal/paypal-messages-android#22)) ([5c4c216](paypal/paypal-messages-android@5c4c216))
* debounce config updates ([#24](paypal/paypal-messages-android#24)) ([d3c79d6](paypal/paypal-messages-android@d3c79d6))
* jetpack compose demo ([#10](paypal/paypal-messages-android#10)) ([c059bca](paypal/paypal-messages-android@c059bca))
* modal updates ([#28](paypal/paypal-messages-android#28)) ([50dac7d](paypal/paypal-messages-android@50dac7d))
* package pre-release ([#14](paypal/paypal-messages-android#14)) ([0189e9e](paypal/paypal-messages-android@0189e9e))
* page type ([#26](paypal/paypal-messages-android#26)) ([cec9ca8](paypal/paypal-messages-android@cec9ca8))
* remove session id and device id ([#35](paypal/paypal-messages-android#35)) ([1fcdbc2](paypal/paypal-messages-android@1fcdbc2))
* session id and device id ([#30](paypal/paypal-messages-android#30)) ([3d24ab1](paypal/paypal-messages-android@3d24ab1))
* update message view to use its own instance id ([#20](paypal/paypal-messages-android#20)) ([c4ab485](paypal/paypal-messages-android@c4ab485))
* use nested coroutine to prevent blocking ([#19](paypal/paypal-messages-android#19)) ([477305d](paypal/paypal-messages-android@477305d))
* xml demo ([#6](paypal/paypal-messages-android#6)) ([7143b6f](paypal/paypal-messages-android@7143b6f))

### Bug Fixes

* allow messages to be updated any time ([#34](paypal/paypal-messages-android#34)) ([d3856fd](paypal/paypal-messages-android@d3856fd))
* correct urls ([#32](paypal/paypal-messages-android#32)) ([adaa98c](paypal/paypal-messages-android@adaa98c))
* general analytics fixes ([#36](paypal/paypal-messages-android#36)) ([580e747](paypal/paypal-messages-android@580e747))
* modal analytics fixes ([#37](paypal/paypal-messages-android#37)) ([7418bac](paypal/paypal-messages-android@7418bac))
* remove kotlinter ([8b5bcf1](paypal/paypal-messages-android@8b5bcf1))
* update shared data ([#7](paypal/paypal-messages-android#7)) ([e5c61f5](paypal/paypal-messages-android@e5c61f5))
* update tracking format ([#33](paypal/paypal-messages-android#33)) ([37f1cfd](paypal/paypal-messages-android@37f1cfd))

### Code Refactoring

* adjust logo alignment ([#23](paypal/paypal-messages-android#23)) ([b012669](paypal/paypal-messages-android@b012669))
* clone to prevent shallow copy ([#25](paypal/paypal-messages-android#25)) ([3e2969f](paypal/paypal-messages-android@3e2969f))
* prevent destroying modal on close ([#3](paypal/paypal-messages-android#3)) ([352756d](paypal/paypal-messages-android@352756d))
* prevent empty values ([#29](paypal/paypal-messages-android#29)) ([4c47cac](paypal/paypal-messages-android@4c47cac))
* radio offer type and other things ([#11](paypal/paypal-messages-android#11)) ([283e2ae](paypal/paypal-messages-android@283e2ae))
* route changes ([#13](paypal/paypal-messages-android#13)) ([52e3dfc](paypal/paypal-messages-android@52e3dfc))
* use dot getters and setters ([#9](paypal/paypal-messages-android#9)) ([11007c2](paypal/paypal-messages-android@11007c2))

### Continuous Integration

* change os ([#38](paypal/paypal-messages-android#38)) ([6337b3c](paypal/paypal-messages-android@6337b3c))
* functional tests ([#16](paypal/paypal-messages-android#16)) ([4f46241](paypal/paypal-messages-android@4f46241))
* lint and test ([#8](paypal/paypal-messages-android#8)) ([51a1364](paypal/paypal-messages-android@51a1364))
* update semantic release ([#21](paypal/paypal-messages-android#21)) ([ec247dd](paypal/paypal-messages-android@ec247dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@grablack grablack grablack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @develop released on @minSdkMatch released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@merlinpaypal @grablack @merlinstardust