Add missing codegen mod in integration tests#1418
Merged
tadeohepperle merged 7 commits intomasterfrom Feb 14, 2024
Merged
Conversation
Collaborator
Make it a draft PR? :) |
niklasad1
reviewed
Feb 9, 2024
| #[cfg(test)] | ||
| mod client; | ||
| #[cfg(test)] | ||
| mod codegen; |
Contributor
There was a problem hiding this comment.
we can probably use in #![cfg(test)] globally here instead repeating test for each module :)
jsdw
approved these changes
Feb 9, 2024
lexnv
reviewed
Feb 13, 2024
| // see LICENSE for license details. | ||
|
|
||
| #[cfg(test)] | ||
| #![cfg(test)] |
Collaborator
There was a problem hiding this comment.
Could we remove this? Since we have a cfg(test) mod full_client in src/lib.rs?
niklasad1
approved these changes
Feb 14, 2024
jsdw
approved these changes
Feb 14, 2024
tadeohepperle
deleted the
tadeohepperle/add-codegen-tests-to-mod-tree
branch
tadeohepperle
added a commit
that referenced
this pull request
Feb 15, 2024
* add codgen mod to the module tree * port codegen tests to scale-typegen * remove test flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module
testing/integration-tests/full_client/codegenwas not included in the module tree before, so the CI never checked it.Don't review yet, there are some old codgen tests, that need fixing since things changed with scale-typegen