Add more tests about generics and deduplication#13
Merged
tadeohepperle merged 3 commits intomasterfrom Mar 12, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some good tests about generics in the subxt/testing/integration-tests/full_client/codegen folder, see paritytech/subxt#1418, that I have ported to scale-typegen, because they are not really subxt-specific.
Question: should we introduce a
deduplicate: bool = true (by default)setting to the TypegenSetting to apply utils::ensure_unique_type_paths automatically? It is easy to forget using it. But this would force us to clone the registry or use a&'a mut PortableRegistryis theTypeGeneratorwhich would be weird...