This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Return RuntimeVersion of overwritten/substituted wasm binary#13066
Merged
Return RuntimeVersion of overwritten/substituted wasm binary#13066
RuntimeVersion of overwritten/substituted wasm binary#13066Conversation
bkchr
added
A0-please_review
…turn-runtime-version
Co-authored-by: Anton <anton.kalyaev@gmail.com>
melekes
approved these changes
Jan 5, 2023
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
👍 (code-wise; don't know enough to reason about business logic)
michalkucharczyk
approved these changes
Jan 5, 2023
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…ytech#13066) * Adds test * Ensure we are using the runtime version of the override/substitute wasm * Update client/service/src/client/call_executor.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> Co-authored-by: Anton <anton.kalyaev@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ytech#13066) * Adds test * Ensure we are using the runtime version of the override/substitute wasm * Update client/service/src/client/call_executor.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> Co-authored-by: Anton <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this pr we always have returned the
RuntimeVersionof the on chain wasm binary, even if there was an overwrite/substitute. This pull requests fixes this by returning always theRuntimeVersionof the used wasm binary. Most of the time these runtime versions should be the same. However, we already had differentRuntimeVersionwhich made the node not detect the correct runtime api version (which are part of the runtime version).