Conversation
9a5aaf4 to
d0c1bec
Compare
|
Re. tx version: Let's check how tx version affects the blockchain behavior in substrate. If it's only for external signer (e.g. hardware or mobile wallet) to distinguish changes in extrinsic args, we'd rather just keep it as is. However, if it affects the security of the blockchain, we have no choice but update it. |
tolak
left a comment
There was a problem hiding this comment.
Go through the pallet-assets and SubBridge relevant changes, LGTM
af02797 to
d759132
Compare
Bump runtimes’ spec to 1209
66382ca to
a4b090d
Compare
# Conflicts: # runtime/khala/src/lib.rs # runtime/rhala/src/lib.rs # runtime/thala/src/lib.rs
|
I shall merge this, feel free to double check it |
|
|
||
| #[derive(Encode, Decode, Debug, TypeInfo)] | ||
| pub struct WorkerInfo { | ||
| pub attestation_provider: Option<AttestationProvider>, |
There was a problem hiding this comment.
Do you remember how it was changed? This message is sent from the pallet to the worker. If the definition is changed, the existing pruntime may not answer properly.
There was a problem hiding this comment.
Kevin says this removing is correct, or it will be problem for PRuntime V2
Because of Cumulus not released 0.9.34 and 0.9.35 so we upgrade from 0.9.33 to 0.9.37
https://github.com/paritytech/polkadot/releases/tag/v0.9.34
https://github.com/paritytech/polkadot/releases/tag/v0.9.35
https://github.com/paritytech/polkadot/releases/tag/v0.9.36
https://github.com/paritytech/polkadot/releases/tag/v0.9.37
paritytech/substrate@polkadot-v0.9.33...polkadot-v0.9.34
paritytech/substrate@polkadot-v0.9.34...polkadot-v0.9.35
paritytech/substrate@polkadot-v0.9.35...polkadot-v0.9.36
paritytech/substrate@polkadot-v0.9.36...polkadot-v0.9.37
Breaking changes:
Notable changes:
EnsureOriginOrHigherPrivilegeparitytech/substrate#12844RuntimeVersionof overwritten/substituted wasm binary paritytech/substrate#13066In addition:
Because of we need to run migrations for assets and balances in this version, I think we should upgrade Phala parachain as well
We need test migration carefully
TODO:--state-pruningissue