Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

add TypeInfo trait bound for pallet-assets' attribute config#10031

Merged
bkchr merged 2 commits intoparitytech:masterfrom
0x8f701:patch-1
Oct 15, 2021
Merged

add TypeInfo trait bound for pallet-assets' attribute config#10031
bkchr merged 2 commits intoparitytech:masterfrom
0x8f701:patch-1

Conversation

@0x8f701
Copy link
Copy Markdown
Contributor

@0x8f701 0x8f701 commented Oct 14, 2021 •
edited
Loading

close: #10030

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 14, 2021
@bkchr bkchr requested review from ascjones and gui1117 October 14, 2021 08:42
ascjones
ascjones approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider rolling TypeInfo into to the Parameter trait, since that already contains Codec.

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 14, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Waiting for commit status.

@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 14, 2021 •
edited
Loading

@bkchr can we backport this to polkadot-v0.9.11 branch? I kind need it for our next release. Thanks~

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Merge aborted: Checks failed for 9a05c90

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 14, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Waiting for commit status.

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Merge aborted: Checks failed for 9a05c90

@0x8f701 0x8f701 mentioned this pull request Oct 14, 2021
Merged
4 tasks
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 14, 2021

@GopherJ can you please merge master

@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 14, 2021 •
edited
Loading

@bkchr can you check now? should be done. I have a very bad network now sorry that I cannot rebase from command line

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 14, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Waiting for commit status.

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2021

Merge aborted: Checks failed for 109c1b6

@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 14, 2021 •
edited
Loading

@bkchr do you know why the CI always fail? Am I wrong on something?

@0x8f701 0x8f701 mentioned this pull request Oct 15, 2021
Merged
5 tasks
@0x8f701 0x8f701 changed the title add TypeInfo trait bound add TypeInfo trait bound for pallet-assets' attribute config Oct 15, 2021
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 15, 2021

@bkchr do you know why the CI always fail? Am I wrong on something?

Not your fault.

@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 15, 2021 •
edited
Loading

@bkchr do you know why the CI always fail? Am I wrong on something?

Not your fault.

Good to know~ can we merge and backport this to polkadot-v0.9.11 branch? I would like to unblock this pr parallel-finance/parallel#693

Great thanks on your help

@bkchr bkchr merged commit afd572f into paritytech:master Oct 15, 2021
bkchr pushed a commit that referenced this pull request Oct 15, 2021
@0x8f701 @bkchr
add TypeInfo trait bound (#10031)
57346f6
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 15, 2021

Backported

@0x8f701 0x8f701 mentioned this pull request Oct 16, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gui1117 gui1117 Awaiting requested review from gui1117

2 more reviewers

@ascjones ascjones ascjones approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assets module's AssetId cannot be used as constant

3 participants

@0x8f701 @bkchr @ascjones