Skip to content

bump polkadot to v0.9.11#693

Merged
0x8f701 merged 37 commits intomasterfrom
feat/polkadot-v0.9.11
Oct 19, 2021
Merged

bump polkadot to v0.9.11#693
0x8f701 merged 37 commits intomasterfrom
feat/polkadot-v0.9.11

Conversation

@0x8f701
Copy link
Copy Markdown
Contributor

@0x8f701 0x8f701 commented Oct 13, 2021

close: #675
close: #658
close: #750

To be finished

TODO:

  • fix Liquid Staking's unit tests
  • update runtime's pallet_balances' weights
  • test producing blocks with parallelfinance/polkadot:v0.9.11
  • test with frontend

@0x8f701 0x8f701 marked this pull request as draft October 13, 2021 08:10
@0x8f701 0x8f701 force-pushed the feat/polkadot-v0.9.11 branch from 807dbc6 to 638391c Compare October 13, 2021 12:46
@0x8f701 0x8f701 marked this pull request as ready for review October 14, 2021 11:32
@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 14, 2021

@0x8f701 0x8f701 force-pushed the feat/polkadot-v0.9.11 branch 2 times, most recently from 3773d82 to 42f650e Compare October 15, 2021 06:43
@yz89
Copy link
Copy Markdown
Contributor

yz89 commented Oct 15, 2021

Please don't merge until we tested the full liquid-staking pallet.

@0x8f701 0x8f701 force-pushed the feat/polkadot-v0.9.11 branch 3 times, most recently from 90fe761 to 2261b65 Compare October 18, 2021 01:24
@0x8f701
Copy link
Copy Markdown
Contributor Author

0x8f701 commented Oct 18, 2021

@ETeissonniere @drbh @ashi20192020ayush we decided to postpone the merge of this PR to be able to deliver web3 grant's milestone 2. So let's use xcm v1 for now, I'll migrate any of your xcm v1 code to v2 in this PR.

In general this PR is also ready but just lack of testing & fixing liquid staking's unit tests, I'll work on fixing it after delivering web3 grant milestone 2

@0x8f701 0x8f701 force-pushed the feat/polkadot-v0.9.11 branch from 4ea3176 to 05b49ce Compare October 18, 2021 15:38
@0x8f701 0x8f701 force-pushed the feat/polkadot-v0.9.11 branch from 83597d9 to 2e2c332 Compare October 19, 2021 05:14
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #693 (13c810a) into master (e13ae1c) will decrease coverage by 0.63%.
The diff coverage is 55.31%.

❗ Current head 13c810a differs from pull request most recent head aaf03bd. Consider uploading reports for the commit aaf03bd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   61.05%   60.42%   -0.64%     
==========================================
  Files          63       63              
  Lines        4727     4677      -50     
==========================================
- Hits         2886     2826      -60     
- Misses       1841     1851      +10     
Impacted Files Coverage Δ
node/parallel/src/command.rs 0.00% <ø> (ø)
node/parallel/src/service.rs 0.00% <0.00%> (ø)
pallets/amm/src/mock.rs 80.00% <ø> (ø)
pallets/currency-adapter/src/lib.rs 45.94% <ø> (ø)
pallets/liquid-staking/src/mock.rs 59.13% <ø> (-8.61%) ⬇️
pallets/liquid-staking/src/tests.rs 100.00% <ø> (ø)
pallets/liquid-staking/src/types.rs 75.00% <ø> (ø)
pallets/liquidation/src/lib.rs 0.00% <0.00%> (ø)
pallets/loans/src/mock.rs 65.71% <ø> (ø)
pallets/loans/src/rate_model.rs 80.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13ae1c...aaf03bd. Read the comment docs.

@0x8f701 0x8f701 merged commit 51d24f9 into master Oct 19, 2021
@0x8f701 0x8f701 deleted the feat/polkadot-v0.9.11 branch October 19, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix WeightNotComputable in feat/polkadot-v0.9.11 branch bump to polkadot-v0.9.11 upgrade the spec_version in heiko runtime

4 participants