Skip to content

Set after to non null#43

Closed
bkchr wants to merge 1 commit into
mainfrom
bkchr-set-after
Closed

Set after to non null#43
bkchr wants to merge 1 commit into
mainfrom
bkchr-set-after

Conversation

@bkchr
Copy link
Copy Markdown
Member

@bkchr bkchr commented Jul 18, 2024

@rzadp would be nice to get a release of this. On chain currently doesn't like after = 0 :D

@bkchr bkchr requested a review from rzadp July 18, 2024 13:08
@bkchr bkchr requested a review from a team as a code owner July 18, 2024 13:08
@rzadp
Copy link
Copy Markdown
Contributor

rzadp commented Jul 18, 2024

@bkchr Does it have something to do with the minEnactmentPeriod value of a track?
If yes, we should set it to 25 because that's the value of minEnactmentPeriod on track fellows, right?

@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Jul 18, 2024

Yeah it is related to the minEnactmentPeriod. With 25 this bug actually does not gets triggered and it is also already fixed. So yeah, the pr is actually not that useful 🙈

@rzadp
Copy link
Copy Markdown
Contributor

rzadp commented Jul 18, 2024

With 25 this bug actually does not gets triggered and it is also already fixed.

Do you mean that the chain actually likes after = 0, and just bumps it to 25? So we can close the PR and continue to set after to 0?

@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Jul 18, 2024

Yeah let's close this! paritytech/polkadot-sdk#4823 this was the bug.

@bkchr bkchr closed this Jul 18, 2024
@bkchr bkchr deleted the bkchr-set-after branch July 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants