Ensure earliest allowed block is at minimum the next block#4823
Merged
Conversation
When `min_enactment_period == 0` and `desired == At(n)` where `n` is smaller than the current block number, the scheduling would fail. This happened for example here: https://collectives.subsquare.io/fellowship/referenda/126 To ensure that this doesn't happen again, ensure that the earliest allowed block is at minimum the next block.
ggwpez
approved these changes
Jun 19, 2024
ordian
approved these changes
Jun 19, 2024
seadanda
approved these changes
Jun 19, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…h#4823) When `min_enactment_period == 0` and `desired == At(n)` where `n` is smaller than the current block number, the scheduling would fail. This happened for example here: https://collectives.subsquare.io/fellowship/referenda/126 To ensure that this doesn't happen again, ensure that the earliest allowed block is at minimum the next block.
This was referenced Aug 21, 2024
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this pull request
Dec 27, 2024
…h#4823) When `min_enactment_period == 0` and `desired == At(n)` where `n` is smaller than the current block number, the scheduling would fail. This happened for example here: https://collectives.subsquare.io/fellowship/referenda/126 To ensure that this doesn't happen again, ensure that the earliest allowed block is at minimum the next block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
min_enactment_period == 0anddesired == At(n)wherenis smaller than the current block number, the scheduling would fail. This happened for example here: https://collectives.subsquare.io/fellowship/referenda/126To ensure that this doesn't happen again, ensure that the earliest allowed block is at minimum the next block.