Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[XCM - UnpaidRemoteExporter] Remove unreachable code #7088

Merged
serban300 merged 2 commits into from
Apr 17, 2023
Merged

[XCM - UnpaidRemoteExporter] Remove unreachable code #7088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23d1307
Remove unreachable code
serban300 Apr 17, 2023
f19a2cf
Fix warning
serban300 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions xcm/xcm-builder/src/universal_exports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,7 @@ impl<Bridges: ExporterFor, Router: SendXcm, UniversalLocation: Get<InteriorMulti
// export for free. Common-good chains will typically be afforded this.
let message =
Xcm(vec![ExportMessage { network: remote_network, destination: remote_location, xcm }]);
let (v, mut cost) = validate_send::<Router>(bridge, message)?;
if let Some(payment) = maybe_payment {
cost.push(payment);
}
let (v, cost) = validate_send::<Router>(bridge, message)?;
Ok((v, cost))
Comment on lines +163 to 164
Copy link
Copy Markdown
Contributor

@KiChjang KiChjang Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to comment that we can actually remove the Ok((v, cost)) and replace the 2 lines with just:

validate_send::<Router>(bridge, message)

Copy link
Copy Markdown
Contributor Author

@serban300 serban300 Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. Sorry, I missed it. I'll open another small PR for this.

}

Expand Down