This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[XCM - UnpaidRemoteExporter] Remove unreachable code#7088
Merged
serban300 merged 2 commits intoparitytech:masterfrom Apr 17, 2023
Merged
[XCM - UnpaidRemoteExporter] Remove unreachable code#7088serban300 merged 2 commits intoparitytech:masterfrom
serban300 merged 2 commits intoparitytech:masterfrom
Conversation
serban300
added
A0-please_review
bkontur
approved these changes
Apr 17, 2023
franciscoaguirre
approved these changes
Apr 17, 2023
KiChjang
reviewed
Apr 17, 2023
Comment on lines
+163
to
164
| let (v, cost) = validate_send::<Router>(bridge, message)?; | ||
| Ok((v, cost)) |
Contributor
There was a problem hiding this comment.
I was about to comment that we can actually remove the Ok((v, cost)) and replace the 2 lines with just:
validate_send::<Router>(bridge, message)
Contributor
Author
There was a problem hiding this comment.
Oh right. Sorry, I missed it. I'll open another small PR for this.
Merged
ordian
added a commit
that referenced
this pull request
Apr 26, 2023
* master: (30 commits) update rocksdb to 0.20.1 (#7113) Reduce base proof size weight component to zero (#7081) PVF: Move PVF workers into separate crate (#7101) Companion for #13923 (#7111) update safe call filter (#7080) PVF: Don't dispute on missing artifact (#7011) XCM: Properly set the pricing for the DMP router (#6843) pvf: Update docs for PVF artifacts (#6551) Bump syn from 2.0.14 to 2.0.15 (#7093) Companion for substrate#13771 (#6983) Added Dwellir Nigeria bootnodes. (#7097) Companion for Substrate #13889 (#7063) Switch to DNS name based bootnodes for Rococo (#7040) companion for substrate#13883 (#7059) [xcm] Added `UnpaidExecution` instruction to `UnpaidRemoteExporter` (#7091) Bump serde_json from 1.0.85 to 1.0.96 (#7072) Bump hex-literal from 0.3.4 to 0.4.1 (#7071) Small simplification (#7089) [XCM - UnpaidRemoteExporter] Remove unreachable code (#7088) sync versions with current release (#7083) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an
ensure!(maybe_payment.is_none(), Unroutable);above, so this code shouldn't be reachable.