This repository was archived by the owner on Nov 15, 2023. It is now read-only.
malus: dont panic on missing validation data#6952
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Apr 26, 2023
Merged
malus: dont panic on missing validation data#6952paritytech-processbot[bot] merged 3 commits intomasterfrom
paritytech-processbot[bot] merged 3 commits intomasterfrom
Conversation
ordian
added
A0-please_review
sandreim
approved these changes
Mar 24, 2023
|
|
||
| [features] | ||
| default = [] | ||
| fast-runtime = ["polkadot-cli/fast-runtime"] |
Author
There was a problem hiding this comment.
I'm not 100% sure anymore, but it doesn't hurt either 🤣
eskimor
approved these changes
Mar 24, 2023
Member
eskimor
left a comment
eskimor
left a comment
There was a problem hiding this comment.
I find those errors a bit disturbing. Is the discarded state expected and if so why?
Author
I encountered this only on my local potato machine running multiple nodes. But also seen this sometimes in the kusama logs |
Author
|
bot merge |
ordian
added a commit
that referenced
this pull request
Apr 26, 2023
* master: malus: dont panic on missing validation data (#6952) Offences Migration v1: Removes `ReportsByKindIndex` (#7114) Fix stalling dispute coordinator. (#7125) Fix rolling session window (#7126) [ci] Update buildah command and version (#7128) Bump assigned_slots params (#6991) XCM: Remote account converter (#6662) Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968) Revert default proof size back to 64 KB (#7115)
ordian
added a commit
that referenced
this pull request
Apr 26, 2023
* master: (39 commits) malus: dont panic on missing validation data (#6952) Offences Migration v1: Removes `ReportsByKindIndex` (#7114) Fix stalling dispute coordinator. (#7125) Fix rolling session window (#7126) [ci] Update buildah command and version (#7128) Bump assigned_slots params (#6991) XCM: Remote account converter (#6662) Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968) Revert default proof size back to 64 KB (#7115) update rocksdb to 0.20.1 (#7113) Reduce base proof size weight component to zero (#7081) PVF: Move PVF workers into separate crate (#7101) Companion for #13923 (#7111) update safe call filter (#7080) PVF: Don't dispute on missing artifact (#7011) XCM: Properly set the pricing for the DMP router (#6843) pvf: Update docs for PVF artifacts (#6551) Bump syn from 2.0.14 to 2.0.15 (#7093) Companion for substrate#13771 (#6983) Added Dwellir Nigeria bootnodes. (#7097) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed spurious failures when testing #6811.
Sometimes, we get
AssumptionCheckOutcome::BadRequestfrom validation data request, I guess because of pruning