This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Change request-response protocol names to include genesis hash & fork id#5870
Merged
dmitry-markin merged 12 commits intomasterfrom Aug 12, 2022
Merged
Change request-response protocol names to include genesis hash & fork id#5870dmitry-markin merged 12 commits intomasterfrom
dmitry-markin merged 12 commits intomasterfrom
Conversation
dmitry-markin
added
A0-please_review
bkchr
reviewed
Aug 10, 2022
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Some nitpicks, but looks good in general.
|
How do we make sure not to have a conflicting protocol name with substrate? E.g. if someone later uses |
Member
|
dmitry-markin
added
A8-mergeoncegreen
and removed
A0-please_review
ordian
added a commit
that referenced
this pull request
Aug 15, 2022
* master: Transaction payment runtime apis: query call info and fee details (#5871) [ci] Improve cancel-pipeline job (#5874) Bump wasmtime from 0.38.1 to 0.38.3 (#5802) Incorporate changes from substrate PR #11908 (#5815) Add nomination pools to Polkadot runtime (#5582) Change request-response protocol names to include genesis hash & fork id (#5870) [ci] Run check-runtime only for PRs (#5858) Bump tokio from 1.18.2 to 1.19.2 (#5678) Zombienet: test disputes with malus garbage candidates (#5857) add unit tests to run runtime migrations (#5865) Trivial networking changes for Substrate PR #11940 (#5841) Renaming CLI prunning and keep-blocks flags (#5863) Update yamux to fix a potential crash (#5861)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR to paritytech/substrate#11938 to rename Polkadot request-response protocols similarly to Substrate changes, originally discussed in paritytech/substrate#7746.
Open questions
This PR doesn't cover all Polkadot protocols --- changing
validation&collationnotification protocols requires a bit of refactoring, so I'm going to create a different PR for them. Please let me know if I missed some other protocols.