add unit tests to run runtime migrations#5865
add unit tests to run runtime migrations#5865paritytech-processbot[bot] merged 6 commits intomasterfrom
Conversation
kianenigma
added
A0-please_review
runtime/westend/src/lib.rs
Outdated
| .to_string() | ||
| .into(); | ||
| let maybe_state_snapshot: Option<SnapshotConfig> = | ||
| std::option_env!("SNAP").map(|s| s.to_string().into()); |
There was a problem hiding this comment.
Why not parse the env variable at runtime? Why at compile time?
There was a problem hiding this comment.
no particular preference to be honest, I supposedly had the syntax for this on the top of my head 🤷
There was a problem hiding this comment.
I think its better to do at runtime, we had CI problems in the past where the CI did not provide the ENV variables.
Co-authored-by: Mara Robin B. <mara@broda.me>
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
So this allows to run the try-runtime as a rust test? Very cool!
I think this is fine for PR testing, but before release we should still execute stuff with wasm |
|
bot merge |
* master: Transaction payment runtime apis: query call info and fee details (#5871) [ci] Improve cancel-pipeline job (#5874) Bump wasmtime from 0.38.1 to 0.38.3 (#5802) Incorporate changes from substrate PR #11908 (#5815) Add nomination pools to Polkadot runtime (#5582) Change request-response protocol names to include genesis hash & fork id (#5870) [ci] Run check-runtime only for PRs (#5858) Bump tokio from 1.18.2 to 1.19.2 (#5678) Zombienet: test disputes with malus garbage candidates (#5857) add unit tests to run runtime migrations (#5865) Trivial networking changes for Substrate PR #11940 (#5841) Renaming CLI prunning and keep-blocks flags (#5863) Update yamux to fix a potential crash (#5861)
5 participants
We should not replace the try-runtime testing in release process with this, as this is all executing in native and is not realistic. Nonetheless, this can now be toyed with as simple as: