Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

zombienet: try to fix parachains upgrade test#5724

Merged
paritytech-processbot[bot] merged 15 commits intomasterfrom
ao-fix-zombienet-parachain-upgrade
Jun 28, 2022
Merged

zombienet: try to fix parachains upgrade test#5724
paritytech-processbot[bot] merged 15 commits intomasterfrom
ao-fix-zombienet-parachain-upgrade

Conversation

@ordian
Copy link
Copy Markdown

@ordian ordian commented Jun 23, 2022

No description provided.

@ordian ordian added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 23, 2022
@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 23, 2022
@pepoviola
Copy link
Copy Markdown
Contributor

pepoviola commented Jun 25, 2022

Hi @ordian, upgrade test fixed now 😀.

Thanks!

ordian added 4 commits June 25, 2022 16:08
@ordian
Revert "try setting cumulusBased"
ac5b732 
This reverts commit 0312fa0.
@ordian
Revert "update command for test"
5923fe2 
This reverts commit 81707e3.
@ordian
Revert "change image"
11545b6 
This reverts commit 43a4f4a.
@ordian
Merge branch 'master' into ao-fix-zombienet-parachain-upgrade
06bebff 
* master:
  Bump `wasmtime` to 0.38.0 and `zstd` to 0.11.2 (companion for substrate#11720) (#5707)
  pvf: ensure enough stack space (#5712)
  Bump generic-array from 0.12.3 to 0.12.4 in /bridges/fuzz/storage-proof (#5648)
  pvf: unignore `terminates_on_timeout` test (#5722)
@ordian
Copy link
Copy Markdown
Author

ordian commented Jun 25, 2022

Hi @ordian, upgrade test fixed now grinning.

Thanks!

Thanks @pepoviola! I've reverted cumulus image change, it should work with the previous image, right? If not, I'll revert it back to c83b292.

@pepoviola
Copy link
Copy Markdown
Contributor

pepoviola commented Jun 25, 2022

Yes

Hi @ordian, upgrade test fixed now grinning.
Thanks!

Thanks @pepoviola! I've reverted cumulus image change, it should work with the previous image, right? If not, I'll revert it back to c83b292.

Yes, works with that image too. Thanks!

@ordian
Copy link
Copy Markdown
Author

ordian commented Jun 27, 2022

This validator image is fixed to the latest release. I think we should change it to a PR branch.

ordian
ordian commented Jun 27, 2022
View reviewed changes
.gitlab-ci.yml
image: "${ZOMBIENET_IMAGE}"
<<: *kubernetes-env
<<: *zombienet-refs
image: "docker.io/paritytech/zombienet:v1.2.45"
Copy link
Copy Markdown
Author

@ordian ordian Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we instead update the env variable ZOMBIENET_IMAGE?

Copy link
Copy Markdown
Contributor

@pepoviola pepoviola Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will update the image for all the tests. I can do that in a followup pr.
Thx!

@ordian ordian marked this pull request as ready for review June 27, 2022 10:13
@ordian ordian requested a review from a team as a code owner June 27, 2022 10:13
@paritytech-ci paritytech-ci requested a review from a team June 27, 2022 10:19
@ordian ordian added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 27, 2022
@sandreim
Copy link
Copy Markdown
Contributor

sandreim commented Jun 28, 2022

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jun 28, 2022

Error: Statuses failed for 65f3bd9

@ordian
Copy link
Copy Markdown
Author

ordian commented Jun 28, 2022

needs one more core-devs approval

@ordian ordian requested a review from vstakhov June 28, 2022 09:00
@ordian
Copy link
Copy Markdown
Author

ordian commented Jun 28, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7096430 into master Jun 28, 2022
@paritytech-processbot paritytech-processbot bot deleted the ao-fix-zombienet-parachain-upgrade branch June 28, 2022 09:15
eskimor
eskimor reviewed Jun 28, 2022
View reviewed changes
zombienet_tests/smoke/0002-parachains-upgrade-smoke-test.toml
[parachains.collator]
name = "collator01"
image = "{{COL_IMAGE}}"
commandWithArgs = "polkadot-collator --collator --alice --force-authoring --tmp --parachain-id 100 --rpc-cors all --unsafe-rpc-external --rpc-methods unsafe --unsafe-ws-external -- --execution wasm --chain /cfg/rococo-local.json --bootnodes /dns/bootnode/tcp/30333/p2p/12D3KooWEyoppNCUx8Yx66oV9fJnriXwCcXwDDUA2kj6vnc6iDEp"
Copy link
Copy Markdown
Member

@eskimor eskimor Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those args no longer needed?

Copy link
Copy Markdown
Contributor

@sandreim sandreim Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters are added by zombienet automatically. We have the cumulus_based = true option which does that trick.

Copy link
Copy Markdown
Author

@ordian ordian Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's handled by zombienet (some args inferred by cumulus_based):
https://github.com/paritytech/zombienet/blob/465622bc84f9824d8c712cc8aef74f4ee223ab0d/src/cmdGenerator.ts#L40

ordian added a commit that referenced this pull request Jun 28, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
65146ca 
* master:
  zombienet: try to fix parachains upgrade test (#5724)
  Update dependencies (companion for substrate#11722) (#5731)
  Update metric name and doc (#5716)
  Bump reqwest from 0.11.10 to 0.11.11 (#5732)
  add release-engineering to CI files' reviewers (#5733)
  Bump parity-scale-codec from 3.1.2 to 3.1.5 (#5720)
  Add checklist item (#5715)
  Fix 5560: add support for a new `staking-miner info` command (#5577)
  Bump `wasmtime` to 0.38.0 and `zstd` to 0.11.2 (companion for substrate#11720) (#5707)
  pvf: ensure enough stack space (#5712)
  Bump generic-array from 0.12.3 to 0.12.4 in /bridges/fuzz/storage-proof (#5648)
  pvf: unignore `terminates_on_timeout` test (#5722)
  Bump proc-macro2 from 1.0.39 to 1.0.40 (#5719)
  pass $COMPANION_OVERRIDES to check_dependent_project (#5708)
  Bump thread_local from 1.1.0 to 1.1.4 in /bridges/fuzz/storage-proof (#5687)
  Bump quote from 1.0.18 to 1.0.19 (#5700)
  Rococo: add new pallet-beefy-mmr API (companion for substrate#11406) (#5516)
  Update metric before bailing out (#5706)
  Add publish docker staking-miner (#5710)
ordian added a commit that referenced this pull request Jul 12, 2022
@ordian
Merge branch 'master' into bernhard-split-network-bridge-into-two-sub…
687ae9a 
…systems

* master: (39 commits)
  Implement prune only stagnant check mode (#5761)
  Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769)
  Update release-99_bot.yml (#5764)
  Version bump to v0.9.26/9260 (#5755)
  Rename `extra_constant` (#5749)
  Bump wasmtime from 0.38.0 to 0.38.1 (#5741)
  Several small fixes to the templates of the release notes (#5756)
  Backports from 0.9.25 (#5754)
  Remove bridges subtree (#5752)
  [Zombienet] test deregister validator (#5718)
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
  zombienet: try to fix parachains upgrade test (#5724)
  Update dependencies (companion for substrate#11722) (#5731)
  Update metric name and doc (#5716)
  Bump reqwest from 0.11.10 to 0.11.11 (#5732)
  ...
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@ordian @pepoviola
zombienet: try to fix parachains upgrade test (#5724)
551dd83 
* zombienet: try to fix parachains upgrade test

* try a different collator image

* Revert "try a different collator image"

This reverts commit c83b292.

* try setting cumulusBased

* fix zombienet upgrade test

* change image

* update command for test

* update zombienet image

* bump zombienet version

* bump zn version

* Revert "try setting cumulusBased"

This reverts commit 0312fa0.

* Revert "update command for test"

This reverts commit 81707e3.

* Revert "change image"

This reverts commit 43a4f4a.

* zombienet: change validator image to a PR branch

Co-authored-by: Javier Viola <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

6 more reviewers

@eskimor eskimor eskimor left review comments

@sandreim sandreim sandreim approved these changes

@pepoviola pepoviola pepoviola approved these changes

@vstakhov vstakhov vstakhov approved these changes

@TriplEight TriplEight TriplEight approved these changes

@alvicsam alvicsam alvicsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ordian @pepoviola @sandreim @vstakhov @eskimor @TriplEight @alvicsam