[Zombienet] test deregister validator by pepoviola · Pull Request #5718 · paritytech/polkadot

pepoviola · 2022-06-22T18:23:21Z

ping @sandreim
This add one test to check the correct value of polkadot_node_is_active_validator.

Thanks!

Signed-off-by: Andrei Sandu <[email protected]>

…gister-validator

sandreim · 2022-06-23T07:44:12Z

There is an error at startup - Error: Invalid chain spec raw file generated. Maybe related to zombienet:v1.2.42 ?

sandreim

LGTM

.gitlab-ci.yml

Co-authored-by: Alexander Samusev <[email protected]>

.gitlab-ci.yml

Co-authored-by: Alexander Samusev <[email protected]>

Signed-off-by: Andrei Sandu <[email protected]>

sandreim · 2022-06-27T10:09:01Z

@pepoviola I've fixed an issue in the JS (the stash account was wrong), but the test keeps failing. It seems to be some sort of issue with metric fetching in Zombienet.

1) ( Deregister / Register Validator Smoke )
       dave: reports polkadot_node_is_active_validator is 0 within 180 secs:

      AssertionError: expected 1 to equal 0
      + expected - actual

      -1
      +0

At the same time I query the respective node metric endpoint and I get:

# HELP polkadot_node_is_active_validator Tracks if the validator is in the active set. Updates at session boundary.
# TYPE polkadot_node_is_active_validator gauge
polkadot_node_is_active_validator{chain="rococo_local_testnet"} 0

pepoviola · 2022-06-27T10:12:11Z

@pepoviola I've fixed an issue in the JS (the stash account was wrong), but the test keeps failing. It seems to be some sort of issue with metric fetching in Zombienet.
1) ( Deregister / Register Validator Smoke )
       dave: reports polkadot_node_is_active_validator is 0 within 180 secs:

      AssertionError: expected 1 to equal 0
      + expected - actual

      -1
      +0
At the same time I query the respective node metric endpoint and I get:
# HELP polkadot_node_is_active_validator Tracks if the validator is in the active set. Updates at session boundary.
# TYPE polkadot_node_is_active_validator gauge
polkadot_node_is_active_validator{chain="rococo_local_testnet"} 0

Ahh thanks for the fix! Checking the metrics cache now.
Thx!

zombienet_tests/smoke/0003-deregister-register-validator-smoke.feature

…t-test-deregister-validator

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20. - [Release notes](https://github.com/dtolnay/quote/releases) - [Commits](dtolnay/quote@1.0.19...1.0.20) --- updated-dependencies: - dependency-name: quote dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* propose fix fees * add tests to kusama runtime as well * better tests * last change * last update * Fix test * ignore tests again

* staking-miner: CLI flag delay solution x secs * Update utils/staking-miner/src/monitor.rs * Update utils/staking-miner/src/opts.rs * more logging * add more verbose logging * Update utils/staking-miner/src/opts.rs Co-authored-by: David <[email protected]> * Update utils/staking-miner/src/opts.rs Co-authored-by: David <[email protected]> * remove redundant check Co-authored-by: David <[email protected]>

pepoviola · 2022-07-03T14:40:25Z

ping @sandreim deregister/register test fixed.
Thanks!

chevdor

LGTM besides the 2 missing EOF

zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

zombienet_tests/smoke/0003-deregister-register-validator.js

….toml Co-authored-by: Chevdor <[email protected]>

Co-authored-by: Chevdor <[email protected]>

sandreim · 2022-07-05T18:42:53Z

bot merge

…systems * master: (39 commits) Implement prune only stagnant check mode (#5761) Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769) Update release-99_bot.yml (#5764) Version bump to v0.9.26/9260 (#5755) Rename `extra_constant` (#5749) Bump wasmtime from 0.38.0 to 0.38.1 (#5741) Several small fixes to the templates of the release notes (#5756) Backports from 0.9.25 (#5754) Remove bridges subtree (#5752) [Zombienet] test deregister validator (#5718) Fix regexp to find the repo name (#5751) Limit stagnant checks to a certain amount of entries (#5742) fix(staking miner): check latest state in solution (#5744) staking-miner: CLI flag delay solution x secs (#5734) backport minimum weight to fee to master (#5739) Bump quote from 1.0.19 to 1.0.20 (#5736) zombienet: try to fix parachains upgrade test (#5724) Update dependencies (companion for substrate#11722) (#5731) Update metric name and doc (#5716) Bump reqwest from 0.11.10 to 0.11.11 (#5732) ...

* Update metric name and doc Signed-off-by: Andrei Sandu <[email protected]> * add test and rename metric to use * change within time for test * Update .gitlab-ci.yml Co-authored-by: Alexander Samusev <[email protected]> * Update .gitlab-ci.yml Co-authored-by: Alexander Samusev <[email protected]> * Properly format the stash account Signed-off-by: Andrei Sandu <[email protected]> * Update test Signed-off-by: Andrei Sandu <[email protected]> * change metric name * Bump quote from 1.0.19 to 1.0.20 (#5736) Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20. - [Release notes](https://github.com/dtolnay/quote/releases) - [Commits](dtolnay/quote@1.0.19...1.0.20) --- updated-dependencies: - dependency-name: quote dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * backport minimum weight to fee to master (#5739) * propose fix fees * add tests to kusama runtime as well * better tests * last change * last update * Fix test * ignore tests again * staking-miner: CLI flag delay solution x secs (#5734) * staking-miner: CLI flag delay solution x secs * Update utils/staking-miner/src/monitor.rs * Update utils/staking-miner/src/opts.rs * more logging * add more verbose logging * Update utils/staking-miner/src/opts.rs Co-authored-by: David <[email protected]> * Update utils/staking-miner/src/opts.rs Co-authored-by: David <[email protected]> * remove redundant check Co-authored-by: David <[email protected]> * fix(staking miner): check latest state in solution (#5744) * bump zombienet version and fix test * Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml Co-authored-by: Chevdor <[email protected]> * Update zombienet_tests/smoke/0003-deregister-register-validator.js Co-authored-by: Chevdor <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Niklas Adolfsson <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Chevdor <[email protected]>

sandreim and others added 3 commits June 22, 2022 14:43

Update metric name and doc

ef42031

Signed-off-by: Andrei Sandu <[email protected]>

add test and rename metric to use

3ae9a38

change within time for test

90f0729

pepoviola requested a review from sandreim June 22, 2022 18:23

pepoviola requested a review from a team as a code owner June 22, 2022 18:23

github-actions bot added the A0-please_review Pull request needs code review. label Jun 22, 2022

pepoviola added I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 22, 2022

Merge branch 'sandreim/fix_metric_confusion' into zombienet-test-dere…

ea484ca

…gister-validator

sandreim mentioned this pull request Jun 23, 2022

Fix confusing metric naming #5716

Merged

sandreim reviewed Jun 23, 2022

View reviewed changes

alvicsam suggested changes Jun 23, 2022

View reviewed changes

.gitlab-ci.yml Show resolved Hide resolved

paritytech-ci requested a review from a team June 23, 2022 09:40

Update .gitlab-ci.yml

0eac156

Co-authored-by: Alexander Samusev <[email protected]>

alvicsam suggested changes Jun 23, 2022

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

paritytech-ci requested a review from a team June 23, 2022 10:22

Update .gitlab-ci.yml

2601276

Co-authored-by: Alexander Samusev <[email protected]>

alvicsam approved these changes Jun 23, 2022

View reviewed changes

paritytech-ci requested a review from a team June 23, 2022 10:25

sandreim added 2 commits June 27, 2022 10:01

Properly format the stash account

fee7b96

Signed-off-by: Andrei Sandu <[email protected]>

Update test

6f870b4

Signed-off-by: Andrei Sandu <[email protected]>

sandreim mentioned this pull request Jun 27, 2022

Sometimes metric matching doesn't work when value changes between queries paritytech/zombienet#250

Closed

change metric name

0af72dc

sandreim reviewed Jun 28, 2022

View reviewed changes

zombienet_tests/smoke/0003-deregister-register-validator-smoke.feature Show resolved Hide resolved

zombienet_tests/smoke/0003-deregister-register-validator-smoke.feature Show resolved Hide resolved

paritytech-ci requested a review from a team June 28, 2022 09:09

Base automatically changed from sandreim/fix_metric_confusion to master June 28, 2022 09:10

sandreim and others added 6 commits June 28, 2022 09:19

Merge branch 'master' of github.com:paritytech/polkadot into zombiene…

257be74

…t-test-deregister-validator

backport minimum weight to fee to master (#5739)

979ba30

* propose fix fees * add tests to kusama runtime as well * better tests * last change * last update * Fix test * ignore tests again

fix(staking miner): check latest state in solution (#5744)

d5526ae

bump zombienet version and fix test

b42e9b5

paritytech-ci requested review from a team July 3, 2022 13:37

pepoviola marked this pull request as draft July 3, 2022 13:39

Merge branch 'master' into zombienet-test-deregister-validator

7caa11e

pepoviola marked this pull request as ready for review July 3, 2022 13:53

chevdor approved these changes Jul 4, 2022

View reviewed changes

zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml Outdated Show resolved Hide resolved

zombienet_tests/smoke/0003-deregister-register-validator.js Outdated Show resolved Hide resolved

sandreim and others added 2 commits July 4, 2022 12:05

Update zombienet_tests/smoke/0003-deregister-register-validator-smoke…

3531fa4

….toml Co-authored-by: Chevdor <[email protected]>

Update zombienet_tests/smoke/0003-deregister-register-validator.js

94da821

Co-authored-by: Chevdor <[email protected]>

sandreim self-requested a review July 5, 2022 12:18

sandreim approved these changes Jul 5, 2022

View reviewed changes

paritytech-processbot bot merged commit fb2c9ae into master Jul 5, 2022

paritytech-processbot bot deleted the zombienet-test-deregister-validator branch July 5, 2022 18:43

librelois mentioned this pull request Jul 19, 2022

Update substrate/polkadot/cumulus from v0.9.23 to v0.9.26 moonbeam-foundation/moonbeam#1691

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Zombienet] test deregister validator#5718

[Zombienet] test deregister validator#5718
paritytech-processbot[bot] merged 18 commits intomasterfrom
zombienet-test-deregister-validator

pepoviola commented Jun 22, 2022

Uh oh!

sandreim commented Jun 23, 2022

Uh oh!

sandreim left a comment

Uh oh!

Uh oh!

Uh oh!

sandreim commented Jun 27, 2022

Uh oh!

pepoviola commented Jun 27, 2022

Uh oh!

Uh oh!

Uh oh!

pepoviola commented Jul 3, 2022

Uh oh!

chevdor left a comment

Uh oh!

Uh oh!

Uh oh!

sandreim commented Jul 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

pepoviola commented Jun 22, 2022

Uh oh!

sandreim commented Jun 23, 2022

Uh oh!

sandreim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sandreim commented Jun 27, 2022

Uh oh!

pepoviola commented Jun 27, 2022

Uh oh!

Uh oh!

Uh oh!

pepoviola commented Jul 3, 2022

Uh oh!

chevdor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sandreim commented Jul 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants