This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/malus_improvement Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
github-actions
bot
added
the
A3-in_progress
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim
added
B0-silent
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…lkadot into sandreim/more_dispute_tests_2 Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
#4711 Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com> Co-authored-by: Andrei Sandu <andrei-mihail@parity.io> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/malus_improvement Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…lkadot into sandreim/more_dispute_tests_2
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
github-actions
bot
added
A0-please_review
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…lkadot into sandreim/more_dispute_tests_2
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…lkadot into sandreim/more_dispute_tests_2
drahnr
reviewed
Apr 12, 2022
| malus-validator-2: reports node_roles is 4 | ||
|
|
||
|
|
||
| honest-validator-0: parachain 2000 block height is at least 4 within 180 seconds |
Contributor
There was a problem hiding this comment.
4 blocks after 180 is a safeguard for cascaded startup delay, correct?
drahnr
reviewed
Apr 12, 2022
| honest-validator-8: reports parachain_disputes_finality_lag is lower than 4 | ||
| honest-validator-9: reports parachain_disputes_finality_lag is lower than 4 | ||
|
|
||
| honest-validator-0: reports parachain_candidate_disputes_total is at least 4 within 15 seconds |
Contributor
There was a problem hiding this comment.
We expect all 4 blocks produced to be disputed. ✔️
drahnr
reviewed
Apr 12, 2022
| honest-validator-2: parachain 2002 block height is at least 4 within 180 seconds | ||
| honest-validator-3: parachain 2003 block height is at least 4 within 180 seconds | ||
|
|
||
| honest-validator-3: log line contains "reverted due to a bad parachain block" within 180 seconds |
Contributor
There was a problem hiding this comment.
That should be the case for all honest validators
drahnr
suggested changes
Apr 12, 2022
Contributor
drahnr
left a comment
drahnr
left a comment
There was a problem hiding this comment.
The assertion file requires some additional comments.
There is also one integration test being deleted - was that intentional?
| honest-validator-6: reports parachain_disputes_finality_lag is lower than 4 | ||
| honest-validator-7: reports parachain_disputes_finality_lag is lower than 4 | ||
| honest-validator-8: reports parachain_disputes_finality_lag is lower than 4 | ||
| honest-validator-9: reports parachain_disputes_finality_lag is lower than 4 |
Contributor
There was a problem hiding this comment.
Could you elaborate what this verifies? I don't quite understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to paritytech/polkadot-sdk#874