This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Malus: improvements in dispute ancestor and suggest garbage candidate implementation#5011
Merged
paritytech-processbot[bot] merged 46 commits intomasterfrom Apr 13, 2022
Merged
Conversation
Signed-off-by: Andrei Sandu <[email protected]>
…/malus_improvement Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
drahnr
reviewed
Mar 4, 2022
drahnr
reviewed
Mar 4, 2022
drahnr
approved these changes
Mar 10, 2022
Contributor
drahnr
left a comment
There was a problem hiding this comment.
A few nits, Valid should be implemented before merging. Besides that - 👍
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
#4711 Co-authored-by: Lldenaurois <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
eskimor
reviewed
Apr 7, 2022
Member
eskimor
left a comment
There was a problem hiding this comment.
First pass, got half way through. Remaining review coming soon.
eskimor
reviewed
Apr 7, 2022
Member
eskimor
left a comment
There was a problem hiding this comment.
Looks good overall - code is clean and relatively easy to follow as well.
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
eskimor
approved these changes
Apr 8, 2022
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
…/malus_improvement Signed-off-by: Andrei Sandu <[email protected]>
drahnr
approved these changes
Apr 11, 2022
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step(s), see #4874
dispute_valid_candidate.rsandsuggest garbage candidate.rs.suggest garbage candidateusing the draft from Malus: Implement storing invalid chunks #4711 as a starting pointThese two malus nemesis implementations will be used in the parachain zombienet test suite:
dispute_valid_candidate)I attached some screenshots to show how
suggest garbage candidatemalus nodes perform in a zombienet test. The first image shows disputes for malicious candidates concluding as valid and the inclusion blocks being finalized. The next two show disputes concluding as invalid and chain reversions.This shows up on honest validators when they run the PVF with a malicious PoV: