This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use only fresh DisputeStatement-s for dispute spam detection (#4921)#4957
Merged
rphmeier merged 1 commit intoparitytech:masterfrom Feb 22, 2022
Merged
Conversation
tdimitrov
added
B0-silent
eskimor
reviewed
Feb 21, 2022
tdimitrov
force-pushed
the
fresh-nodes-spam-slots
branch
from
761611e to
9b9746e
Compare
…ech#4921) handle_import_statements() from Dispute-Coordinator does spam detection by counting unconfirmed dispute statements from each validator. This patch adjusts the logic so that only fresh dispute statements are counted. Fresh dispute statement in this case means a statement which was not loaded from overlay db.
tdimitrov
force-pushed
the
fresh-nodes-spam-slots
branch
from
9b9746e to
4703d6b
Compare
rphmeier
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_import_statements() from Dispute-Coordinator does spam detection
by counting unconfirmed dispute statements from each validator.
This patch adjusts the logic so that only fresh dispute statements are
counted.
Fresh dispute statement in this case means a statement which was not
loaded from overlay db.
Fixes: #4921