This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
rphmeier
added
A3-in_progress
github-actions
bot
added
A0-please_review
eskimor
approved these changes
Feb 7, 2022
ordian
added a commit
that referenced
this pull request
Feb 8, 2022
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 23, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 23, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 25, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 25, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 25, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 28, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Feb 28, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Mar 1, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
added a commit
to tdimitrov/polkadot
that referenced
this pull request
Mar 1, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
eskimor
pushed a commit
that referenced
this pull request
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the original vision was for higher-level subsystems to do deduplication, but that has been lost over time. This PR changes the dispute coordinator to avoid doing any DB writes when a statement is redundant. And also to avoid counting such messages in the metrics.