This repository was archived by the owner on Nov 15, 2023. It is now read-only.
collation-generation: Support compressed PoVs directly#4825
Merged
Conversation
This adds support for returning a compressed PoV directly to the collation generation. This is mainly to not requiring to compress a PoV twice.
bkchr
added
A0-please_review
ordian
approved these changes
Feb 7, 2022
Contributor
|
I asked this before but forgot.. Do we benefit much from compressed PoVs? I'd assume our merkle proofs wind up incompressible? Or did we mess up sometihng there and it would up easier to just compress them? Or maybe this is just the actual block data? |
Member
Author
|
We did not really test it. I would say it depends on the data that is part of the state proof. |
Contributor
|
While compact encoding is used for extrinsic, they are not (generally) used for storages. So that means balances will have a lot of empty bytes which are potentially compressible. |
ordian
added a commit
that referenced
this pull request
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for returning a compressed PoV directly to the
collation generation. This is mainly to not requiring to compress a PoV
twice.
cumulus companion: paritytech/cumulus#942