enable disputes by ordian · Pull Request #3478 · paritytech/polkadot

ordian · 2021-07-15T13:22:37Z

Use RelayChainSelection when instantiating BABE and GRANDPA
Test on Rococo

WARNING: this PR bums the parachain's DB version, which means it's a one-way migration unless you delete the parachain's DB folder.

drahnr

Looks good 👍 , also shows why we need to get rid of AllSubsystems eventually.

Will give it a second pass as soon as the remaining checkmarks are set :)

rphmeier · 2021-07-15T20:39:31Z

node/overseer/src/subsystems.rs

+	/// A Dispute Distribution subsystem.
+	pub dispute_distribution: DD,
+	/// A Chain Selection subsystem.
+	pub chain_selection: CS,


Does this automatically generate communication handling for the subsystems?

This is a barely used abstraction for Overseer::new which will be removed soon™ ( tracked as chore in #3427 ), removing the wip keyword from the #[subsystem(..)] annotation does it.

node/service/src/lib.rs

Co-authored-by: Robert Habermeier <[email protected]>

drahnr · 2021-07-15T20:46:02Z

node/overseer/src/lib.rs

-	#[subsystem(no_dispatch, wip, DisputeDistributionMessage)]
-	dipute_distribution: DisputeDistribution,
+	#[subsystem(no_dispatch, DisputeDistributionMessage)]
+	dispute_distribution: DisputeDistribution,


@rphmeier : Removing the wip hooks up all the channels as expected. I'll write some proper documentation once #3454 is complete.

Woah, I like this "wip" thing.

node/service/src/lib.rs

* master: Update secp256k1 and remove unrequired usage (#3502) Bump libc from 0.2.91 to 0.2.98 (#3496) Bump slotmap from 1.0.2 to 1.0.5 (#3495) Gossip rebroadcast rate limiter (#3494) dependabot: ignore another git dep (#3493) add rustfmt toml (#3491) Disputes runtime (#2947) Bump async-process from 1.0.1 to 1.1.0 (#3122) remove the kubernetes helm chart (#3483) added pallet-proxy in rococo feature dependencies (#3486) Update BEEFY+MMR integration. (#3480) more verbose asserts (#3476) ci: use srtool-actions to build runtimes (#3423) overseer gen minor chore fixes (#3479)

andresilva · 2021-07-21T14:10:41Z

I think we should probably play it safer with enabling the stagnant checks, maybe there should be a mode where we only log about this before rolling it out on Kusama.

rphmeier · 2021-07-21T18:21:17Z

Ok, let's make a small PR where we change the configuration of the chain selection subsystem to prevent turning on the stagnant check worker.

rphmeier · 2021-07-21T22:04:48Z

I pushed a commit to address @andresilva's concerns. However, we should introduce the stagnant check at the same time as removing the training wheels. Otherwise the fork-choice rule may follow a stagnant chain indefinitely.

* master: Reduce staking miner reward (companion `substrate/pull/9395`) (#3465) Parachains shared.rs to Frame V2 (#3425) Parachains hrmp.rs to Frame V2 (#3475) Migrate slots pallet to pallet attribute macro. (#3218) Improve test in bridge (#3507) parachain dmp.rs to Frame V2 (#3426) Parachains inclusion.rs to Frame V2 (#3440) Dispute coordinator - Recover disputes on startup (#3481) Use correct syntax for owning all files in a folder (#3510) Add wococo-local chain spec (#3509) Dispute vote filtering for block authors (#3498) Bump indexmap from 1.6.1 to 1.7.0 (#3497) Companion for substrate #9315 (#3477)

This reverts commit e210505.

drahnr · 2021-07-23T16:15:06Z

node/overseer/src/lib.rs



-/// A handler used to communicate with the [`Overseer`].
+/// A handle used to communicate with the [`Overseer`].


drahnr · 2021-07-23T16:15:28Z

node/overseer/src/lib.rs

-pub struct Handle(pub Option<OverseerHandle>);
+pub enum Handle {
+	/// Used only at initialization to break the cyclic dependency.
+	// TODO: refactor in https://github.com/paritytech/polkadot/issues/3427


* master: enable disputes (#3478) Do not leak active head data in statement distribution (#3519) Fix TransactAsset Implementation (#3345)

ordian added 2 commits July 15, 2021 14:50

initial integration and migration code

478a97b

fix tests

777fe82

ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 15, 2021

ordian added 3 commits July 15, 2021 15:32

fix counting test

8359bb6

assume the current version on missing file

897937b

use SelectRelayChain

e95bc30

ordian marked this pull request as ready for review July 15, 2021 15:37

remove duplicate metric

3f8c664

drahnr reviewed Jul 15, 2021

View reviewed changes

rphmeier reviewed Jul 15, 2021

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

Update node/service/src/lib.rs

b7bc78d

Co-authored-by: Robert Habermeier <[email protected]>

drahnr reviewed Jul 15, 2021

View reviewed changes

drahnr approved these changes Jul 15, 2021

View reviewed changes

rphmeier mentioned this pull request Jul 17, 2021

Tracking issue for Parachain disputes #3255

Closed

28 tasks

rphmeier reviewed Jul 20, 2021

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

ordian added 2 commits July 20, 2021 21:22

remove ApprovalCheckingVotingRule

c3d51b8

ordian linked an issue Jul 21, 2021 that may be closed by this pull request

Enable ApprovalCheckingVotingRule on Polkadot #3326

Closed

ordian removed a link to an issue Jul 21, 2021

Enable ApprovalCheckingVotingRule on Polkadot #3326

Closed

address my concern

4aebe3e

ordian added the E1-database_migration PR introduces code that does a one-way migration of the database. label Jul 21, 2021

never mode for StagnantCheckInterval

4c7e011

ordian added 2 commits July 22, 2021 16:00

REVERTME: some logs

e210505

w00t

d626516

ordian added 4 commits July 23, 2021 13:52

it's ugly but it works

a278e9d

Revert "REVERTME: some logs"

116b885

This reverts commit e210505.

it's handle, not handler

4a89c36

drahnr reviewed Jul 23, 2021

View reviewed changes

drahnr approved these changes Jul 23, 2021

View reviewed changes

fix a few typos

b1a0027

ordian merged commit 2d19780 into master Jul 26, 2021

ordian deleted the ao-enable-disputes branch July 26, 2021 12:46

ordian added a commit that referenced this pull request Jul 26, 2021

Merge branch 'master' into bernhard-integrate-dispute-finality

88fd180

* master: enable disputes (#3478) Do not leak active head data in statement distribution (#3519) Fix TransactAsset Implementation (#3345)

github-actions bot mentioned this pull request Aug 24, 2021

Update substrate/polkadot/cumulus from v0.9.8 to v0.9.9 moonbeam-foundation/moonbeam#729

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable disputes#3478

enable disputes#3478
ordian merged 18 commits intomasterfrom
ao-enable-disputes

ordian commented Jul 15, 2021 •

edited

Loading

Uh oh!

drahnr left a comment

Uh oh!

rphmeier Jul 15, 2021 •

edited

Loading

Uh oh!

drahnr Jul 15, 2021 •

edited

Loading

Uh oh!

Uh oh!

drahnr Jul 15, 2021 •

edited

Loading

Uh oh!

rphmeier Jul 19, 2021

Uh oh!

Uh oh!

andresilva commented Jul 21, 2021 •

edited

Loading

Uh oh!

rphmeier commented Jul 21, 2021

Uh oh!

rphmeier commented Jul 21, 2021

Uh oh!

drahnr Jul 23, 2021

Uh oh!

drahnr Jul 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants



		/// A handler used to communicate with the [`Overseer`].
		/// A handle used to communicate with the [`Overseer`].

Conversation

ordian commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

drahnr left a comment

Choose a reason for hiding this comment

Uh oh!

rphmeier Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drahnr Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drahnr Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rphmeier Jul 19, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andresilva commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphmeier commented Jul 21, 2021

Uh oh!

rphmeier commented Jul 21, 2021

Uh oh!

drahnr Jul 23, 2021

Choose a reason for hiding this comment

Uh oh!

drahnr Jul 23, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ordian commented Jul 15, 2021 •

edited

Loading

rphmeier Jul 15, 2021 •

edited

Loading

drahnr Jul 15, 2021 •

edited

Loading

drahnr Jul 15, 2021 •

edited

Loading

andresilva commented Jul 21, 2021 •

edited

Loading