ci: use srtool-actions to build runtimes#3423
Conversation
chevdor
changed the title
chevdor
added
the
C1-low
s3krit
left a comment
s3krit
left a comment
There was a problem hiding this comment.
Lgtm. So long as the runtime srtool output json file hasn't changed format and is still reachable by publish_draft_release.rb, everything should stll Just Work™ (the job failed on your test run due to you currently having no releases). I'll verify that in my polkadot fork I use for testing release stuff then give this an approval. Cheers!
| path: | | ||
| ${{ steps.srtool_build.outputs.wasm }} | ||
| ${{ steps.srtool_build.outputs.wasm_compressed }} |
There was a problem hiding this comment.
Just curious, what happens when you use two lines for the path here?
There was a problem hiding this comment.
that are the names of two artifacts from id: srtool_build job
There was a problem hiding this comment.
The artifact ${{ matrix.runtime }}-runtime is an id. Listing several files or a pattern means you end up with several files in this artifact.
TriplEight
left a comment
TriplEight
left a comment
There was a problem hiding this comment.
every time I see CI installs something I'm tempted to write an image for this.
| path: | | ||
| ${{ steps.srtool_build.outputs.wasm }} | ||
| ${{ steps.srtool_build.outputs.wasm_compressed }} |
There was a problem hiding this comment.
that are the names of two artifacts from id: srtool_build job
| - name: Set up Ruby 2.7 | ||
| uses: actions/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.7 | ||
| - name: Download srtool json output | ||
| uses: actions/download-artifact@v2 | ||
| - name: Generate release text | ||
| env: | ||
| RUSTC_STABLE: ${{ needs.get-rust-versions.outputs.rustc-stable }} | ||
| RUSTC_NIGHTLY: ${{ needs.get-rust-versions.outputs.rustc-nightly }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gem install changelogerator git toml | ||
| ruby $GITHUB_WORKSPACE/polkadot/scripts/github/generate_release_text.rb | tee release_text.md |
There was a problem hiding this comment.
The PR did not change that content (despite the diff). It looks like the identation changed though.
I did run some formatting.
There was a problem hiding this comment.
Then PR is good, but in general, it's something that would need some love.
I also don't have the Matrix keys/tokens so I did not expect that part to work. |
s3krit
left a comment
s3krit
left a comment
There was a problem hiding this comment.
Cool, verified on my end with a fork that the release generation stuff works as expected
|
bot merge |
|
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
* master: Update secp256k1 and remove unrequired usage (#3502) Bump libc from 0.2.91 to 0.2.98 (#3496) Bump slotmap from 1.0.2 to 1.0.5 (#3495) Gossip rebroadcast rate limiter (#3494) dependabot: ignore another git dep (#3493) add rustfmt toml (#3491) Disputes runtime (#2947) Bump async-process from 1.0.1 to 1.1.0 (#3122) remove the kubernetes helm chart (#3483) added pallet-proxy in rococo feature dependencies (#3486) Update BEEFY+MMR integration. (#3480) more verbose asserts (#3476) ci: use srtool-actions to build runtimes (#3423) overseer gen minor chore fixes (#3479)
3 participants
paritytech/srtooldocker imageI have tested at https://github.com/chevdor/polkadot/actions/runs/1007250044
The compressed runtime is added to the -runtime artifacts.