Skip to content

Add new zepter duplicate-deps check as part of CI#9809

Merged
bkchr merged 7 commits intoparitytech:masterfrom
dimartiro:ci-zepter-duplicate_deps
Sep 26, 2025
Merged

Add new zepter duplicate-deps check as part of CI#9809
bkchr merged 7 commits intoparitytech:masterfrom
dimartiro:ci-zepter-duplicate_deps

Conversation

@dimartiro
Copy link
Copy Markdown
Contributor

Description

This PR builds on my previous PR and addresses feedback from Basti’s comment here.

To prevent the same situation from recurring in the future, I’ve introduced a new lint check in Zepter, which is now also integrated into the CI workflow. The purpose of this check is to automatically detect and block cases where the same dependency is declared both under [dependencies] and [dev-dependencies].

@dimartiro dimartiro requested a review from a team as a code owner September 22, 2025 13:09
@dimartiro dimartiro requested review from a team as code owners September 22, 2025 13:21
@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Sep 25, 2025
@bkchr bkchr enabled auto-merge September 25, 2025 10:42
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we only run this in the CI and not locally?
Okay, i am not sure if it is 100% stable yet so we can keep it like that. In the future i would change it to also run locally then.

@bkchr bkchr added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2025
@dimartiro
Copy link
Copy Markdown
Contributor Author

So we only run this in the CI and not locally? Okay, i am not sure if it is 100% stable yet so we can keep it like that. In the future i would change it to also run locally then.

@ggwpez what do you mean with locally?

@bkchr bkchr added this pull request to the merge queue Sep 26, 2025
Merged via the queue into paritytech:master with commit d5473e6 Sep 26, 2025
252 of 257 checks passed
bee344 pushed a commit that referenced this pull request Oct 7, 2025
# Description

This PR builds on my previous
[PR](#9233) and addresses
feedback from Basti’s comment
[here](#9283 (comment)).

To prevent the same situation from recurring in the future, I’ve
introduced a new **lint check** in **Zepter**, which is now also
integrated into the CI workflow. The purpose of this check is to
automatically detect and block cases where the same dependency is
declared both under `[dependencies]` and `[dev-dependencies]`.
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
# Description

This PR builds on my previous
[PR](#9233) and addresses
feedback from Basti’s comment
[here](#9283 (comment)).

To prevent the same situation from recurring in the future, I’ve
introduced a new **lint check** in **Zepter**, which is now also
integrated into the CI workflow. The purpose of this check is to
automatically detect and block cases where the same dependency is
declared both under `[dependencies]` and `[dev-dependencies]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants