Add duplicate dependencies check in CI#9283
Add duplicate dependencies check in CI#9283dimartiro wants to merge 1 commit intoparitytech:masterfrom
Conversation
|
@ggwpez maybe something that could be integrated into zepter? |
|
|
||
| This is useful for CI to enforce clean separation between runtime and dev-only dependencies. | ||
|
|
||
| A duplicated dependency is one that appears in both sections with the exact same configuration, |
There was a problem hiding this comment.
What you mean with "exact same configuration"? Features? Or Version / Path stuff?
There was a problem hiding this comment.
All of that, same features, same path, same version, basically if we consider the dependency as
name = value
with "exact same configuration" I mean "same value"
|
@dimartiro I would then like to see this being integrated into zepter: ggwpez/zepter#150 So, for now I'm closing this pr and you can create a new one if you have done the upstream contribution. Ty! |
Yeah I think it's a better way to solve it! thanks for the suggestion |
# Description This PR builds on my previous [PR](#9233) and addresses feedback from Basti’s comment [here](#9283 (comment)). To prevent the same situation from recurring in the future, I’ve introduced a new **lint check** in **Zepter**, which is now also integrated into the CI workflow. The purpose of this check is to automatically detect and block cases where the same dependency is declared both under `[dependencies]` and `[dev-dependencies]`.
# Description This PR builds on my previous [PR](#9233) and addresses feedback from Basti’s comment [here](#9283 (comment)). To prevent the same situation from recurring in the future, I’ve introduced a new **lint check** in **Zepter**, which is now also integrated into the CI workflow. The purpose of this check is to automatically detect and block cases where the same dependency is declared both under `[dependencies]` and `[dev-dependencies]`.
# Description This PR builds on my previous [PR](#9233) and addresses feedback from Basti’s comment [here](#9283 (comment)). To prevent the same situation from recurring in the future, I’ve introduced a new **lint check** in **Zepter**, which is now also integrated into the CI workflow. The purpose of this check is to automatically detect and block cases where the same dependency is declared both under `[dependencies]` and `[dev-dependencies]`.
3 participants
Description
Adds a duplicate dependencies check as part of the CI checks
A duplicate dependency is the one that is present in both
[dependencies]and[dev-dependencies]sectionThis PR depends on #9233 to solve all duplicates before start running the new check in future PRs