Skip to content

[unstable2507] Backport #9544#9600

Merged
bkchr merged 4 commits intounstable2507from
backport-9544-to-unstable2507
Sep 3, 2025
Merged

[unstable2507] Backport #9544#9600
bkchr merged 4 commits intounstable2507from
backport-9544-to-unstable2507

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

@paritytech-release-backport-bot paritytech-release-backport-bot bot commented Aug 28, 2025

Backport #9544 into unstable2507 from franciscoaguirre.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

paritytech-release-backport-bot bot commented Aug 28, 2025

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-9544-to-unstable2507
git worktree add --checkout .worktree/backport-9544-to-unstable2507 backport-9544-to-unstable2507
cd .worktree/backport-9544-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x c1a31e3505c0c4e01b9d2daad5f4d19b220345ec
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Aug 28, 2025
Merged
3 tasks
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Aug 28, 2025
@franciscoaguirre @karolk91
Disable reserve_asset_transfer for DOT (#9544)
7cc0f6f 
- [x] Add check to `do_reserve_asset_transfer`
- [x] Modify existing tests
- [ ] Add new tests if needed

---------

Co-authored-by: Karol Kokoszka <[email protected]>
(cherry picked from commit c1a31e3)
@karolk91 karolk91 force-pushed the backport-9544-to-unstable2507 branch from 3dd9453 to 7cc0f6f Compare August 31, 2025 22:07
@karolk91 karolk91 marked this pull request as ready for review August 31, 2025 22:09
@karolk91 karolk91 requested a review from a team as a code owner August 31, 2025 22:09
@paritytech-workflow-stopper
Copy link
Copy Markdown

paritytech-workflow-stopper bot commented Aug 31, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/17362925381
Failed job name: run-frame-omni-bencher

@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented Sep 2, 2025

unrelated CI failure on check-benches: pallet-revive-fixtures compilation error when using --features runtime-benchmarks:

Compiling testnet-parachains-constants v1.0.0 (/__w/polkadot-sdk/polkadot-sdk/cumulus/parachains/runtimes/constants)
error: failed to run custom build command for `pallet-revive-fixtures v0.1.0 (/__w/polkadot-sdk/polkadot-sdk/substrate/frame/revive/fixtures)`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_DEV_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `/__w/polkadot-sdk/polkadot-sdk/target/debug/build/pallet-revive-fixtures-8e520aa5e0f478d7/build-script-build` (exit status: 1)
  --- stdout
  cargo::rerun-if-env-changed=PALLET_REVIVE_FIXTURES_RUSTUP_TOOLCHAIN
  cargo::rerun-if-env-changed=PALLET_REVIVE_FIXTURES_STRIP
  cargo::rerun-if-env-changed=PALLET_REVIVE_FIXTURES_OPTIMIZE
  cargo::rerun-if-changed=/__w/polkadot-sdk/polkadot-sdk/target/pallet-revive-fixtures
  cargo::rerun-if-changed=/__w/polkadot-sdk/polkadot-sdk/substrate/frame/revive/fixtures
  cargo::rerun-if-changed=/__w/polkadot-sdk/polkadot-sdk/substrate/frame/revive/uapi

  --- stderr
  Error: Failed to execute solc. Make sure solc is installed.

@EgorPopelyaev can you force-merge this fix backport? the changes here are not related to the failing CI

@EgorPopelyaev
Copy link
Copy Markdown
Contributor

EgorPopelyaev commented Sep 3, 2025

@acatangiu @franciscoaguirre Unfortunately I don't have that power, if someone from you guys have it, feel free to do so

@karolk91
Copy link
Copy Markdown
Contributor

karolk91 commented Sep 3, 2025 •
edited
Loading

looks like the issue is missing "solc" compiler within the docker image

image used for unstable2507

polkadot-sdk/.github/env

Line 1 in 928adaf

IMAGE="docker.io/paritytech/ci-unified:bullseye-1.88.0-2025-06-27-v202506301118" 

➜  docker run -it --rm --platform linux/amd64 docker.io/paritytech/ci-unified:bullseye-1.88.0-2025-06-27-v202506301118 which solc

image used for master

polkadot-sdk/.github/env

Line 1 in b8a0571

IMAGE="docker.io/paritytech/ci-unified:bullseye-1.88.0-2025-06-27-v202507221446" 

➜  docker run -it --rm --platform linux/amd64 docker.io/paritytech/ci-unified:bullseye-1.88.0-2025-06-27-v202507221446 which solc
/usr/local/bin/solc

should we switch to newer version of the image?

@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented Sep 3, 2025

should we switch to newer version of the image?

yes

@karolk91 karolk91 mentioned this pull request Sep 3, 2025
Closed
@bkchr bkchr merged commit 64c1314 into unstable2507 Sep 3, 2025
323 of 340 checks passed
@bkchr bkchr deleted the backport-9544-to-unstable2507 branch September 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karolk91 karolk91 karolk91 approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees

No one assigned

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acatangiu @EgorPopelyaev @karolk91 @franciscoaguirre @bkchr