Disable reserve_asset_transfer for DOT#9544
Conversation
|
Seems to be a followup of #9137. Are more follow-up changes expected? |
|
There are no more follow-ups expected. This was also unexpected. It was a case we missed. The solution for anyone doing cross-chain transfers is the same: use You can also use a tool that abstracts away these things like the Paraspell SDK |
franciscoaguirre
added
T6-XCM
| // We check for network native asset reserve transfers in preparation for the Asset Hub | ||
| // Migration. This check will be removed after the migration and the determined | ||
| // reserve location adjusted accordingly. For more information, see https://github.com/paritytech/polkadot-sdk/issues/9054. | ||
| Self::ensure_network_asset_reserve_transfer_allowed( | ||
| &assets, | ||
| fee_asset_item, | ||
| &assets_transfer_type, | ||
| &fees_transfer_type, | ||
| )?; |
There was a problem hiding this comment.
It looks like this change will break the following test:
cargo test -p bridge-hub-westend-integration-tests tests::snowbridge::transfer_relay_token -- --nocapture
FYI: in our WebSDK we use polkadotXcm.transferAssets, which would also be affected by this filter.
Maybe we should whitelist Ethereum as a destination?
There was a problem hiding this comment.
They will, but switching to transfer_assets_using_type_and_then would already work
There was a problem hiding this comment.
IIUC, the issue concerns DOT transfers between two non-reserve (system) chains. By contrast, sending DOT from AH to Ethereum doesn't involve the IsReserve configuration - it's always treated as a local reserve transfer.
Consider that the WebSDK is already in production. I'd suggest avoiding breaking changes if possible.
There was a problem hiding this comment.
@franciscoaguirre I've added a patch in #9585. Please review and let me know if it makes sense.
There was a problem hiding this comment.
Please change the Web-SDK to use the alternative extrinsic. Offchain changes/fixes are much easier to apply/revert/patch/fix/etc.
onchain we keep it simple to minimize corner cases
|
I sadly couldn't figure out the issue with the |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-9544-to-stable2503
git worktree add --checkout .worktree/backport-9544-to-stable2503 backport-9544-to-stable2503
cd .worktree/backport-9544-to-stable2503
git reset --hard HEAD^
git cherry-pick -x c1a31e3505c0c4e01b9d2daad5f4d19b220345ec
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-9544-to-stable2506
git worktree add --checkout .worktree/backport-9544-to-stable2506 backport-9544-to-stable2506
cd .worktree/backport-9544-to-stable2506
git reset --hard HEAD^
git cherry-pick -x c1a31e3505c0c4e01b9d2daad5f4d19b220345ec
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-9544-to-unstable2507
git worktree add --checkout .worktree/backport-9544-to-unstable2507 backport-9544-to-unstable2507
cd .worktree/backport-9544-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x c1a31e3505c0c4e01b9d2daad5f4d19b220345ec
git push --force-with-lease |
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io>
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io> (cherry picked from commit c1a31e3)
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io> (cherry picked from commit c1a31e3)
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io> (cherry picked from commit c1a31e3)
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io> (cherry picked from commit c1a31e3)
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io> (cherry picked from commit c1a31e3)
Backport #9544 into `stable2506` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
Backport #9544 into `stable2503` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
Backport #9544 into `stable2412` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
Backport #9544 into `stable2409` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
Backport #9544 into `unstable2507` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
Update of pallet-xcm in order integrate changes from paritytech/polkadot-sdk#9544 New version of `pallet-xcm` was published from `unstable2507` (paritytech/polkadot-sdk#9643) TODO: - [x] migrate tests using `reserve_transfer_assets`, `limited_reserve_transfer_assets` to `transfer_assets_using_type_and_then` - [x] fix `reserve_transferable_asset_and_dest` benchmarks to use USDT instead of DOT - [x] update `reserve_transfer_assets` weights to `Weight::MAX` for relays - [x] add changelog entry --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
- [x] Add check to `do_reserve_asset_transfer` - [x] Modify existing tests - [ ] Add new tests if needed --------- Co-authored-by: Karol Kokoszka <karol@parity.io>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
6 participants
do_reserve_asset_transfer