Conversation
RafalMirowski1
approved these changes
Aug 19, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
|
test-linux-stable failed. I suppose the compilation errors after the bump should be fixed. |
Contributor
Author
Looks like maybe we need to add one of this features |
Contributor
I think you should use |
Contributor
Author
wait, something is weird, since the latest version of Thx! |
Fixes the benchmarking code of `pallet_session` such that it works with any `KeyDeposit`. Reported by @bkontur in polkadot-fellows/runtimes#855 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
This PR fixes build-binary flow, that is used to build a binary for the testing purposes from any branch. The issue was that there were too many input args for the build script.
# Description Adds a few crate bumps associated to PRs which missed to bump them, and updates parity-publish version across the board to 0.10.6 (to support rustc 1.88). Additionally, makes it so that parity-publish-check-compile runs first on all unreleased prdocs to bump associated crates, and only after moving those to an `unreleased` directory, runs on the current PR's prdoc. This is so that we first create a "local release" based on the unreleased prdocs, and then we follow with a "patch" release based on the previous local release, considering only the prdoc pushed with the current PR. If the workflow fails at the end it means current PR missed certain bumps. If we don't do the plan/apply twice we risk to miss bumps due to all prdocs being considered (current PR's prdoc + unreleased ones) when running parity-publish plan/apply, which might result in a set of crate bumps which are sufficient, but once some unreleased prdocs will be moved to a stable prodoc directory, because they will be part of a stable release, then the ones left will not be enough from a bump perspective (e.g. like it happened in #9320). That's why it is important to check every PR that adds a prdoc whether it is self-sufficient from a crates bumping perspective. If no prdoc is provided, the parity-publish does not need to be taken into consideration, but it should also pass nonetheless. ## Integration N/A ## Review Notes There seems to a be a corner case parity-publish can not easily catch. All bumps below are a manifestation of it. More details below: * #8714 - a major bump is necessary for `sp-wasm-interface` - context here: #8714 (comment) * `sp-keystore` was bumped during 2506 in #6010 , and the relevant prdoc got moved to stable2506 dir in #9320. This moved prdoc coexisted alongside other unreleased prdocs, and covered a needed patch bump for `sp-keystore`, that is not easily visible, and also required for crates publishing IIUC: 1. `sp-io` is major bumped because its direct dependency, `sp-state-machine`, was major bumped. 2. `sp-io` has a direct dependency on `sp-core` (minor bumped), and `sp-keystore` (not touched, not bumped by now) 3. `sp-io` fails to compile because it pulls same types from different `sp-core` versions (it implements `Keystore` trait from `sp-keystore` with methods signatures referencing types from `sp-core 38.0.0` by using the `sp-core 0.38.1` - unreleased yet - types, which confuses rustc). * `sp-rpc` needs a bump too due to pulling `sp-core 38.0.0`, like `sp-keystore`, and it is an indirect dependency of `polkadot-cli`, which has also a direct dependency on unreleased `sp-core 38.1.0`, so again, if we don't bump `sp-rpc` (historically it has been bumped only with major, but I think we can go with patch on this one), `polkadot-cli` can't compile. * `sc-storage-monitor` is in a similar situation as `sp-rpc`/`sp-keystore` - `polkadot-cli` depends on `sc-storage-monitor` (which is not bumped, and has a dependency on `sp-core 38.0.0`), but it also depends on `sp-core 38.1.0`. And yet again, something is used in `polkadot-cli` from the two different `sp-core` versions, which confuses rustc. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
- Added 2 jobs to `Release - Build node release candidate` CI workflow for linux/mac subkey binaries - Added 2 jobs to `RC Build` CI workflow to upload linux/mac `subkey` artifacts to S3 - updated `release_lib.sh` to reflect new S3 artifacts CLOSES: #9465 --------- Co-authored-by: EgorPopelyaev <egor@parity.io>
# Description `publish-check-compile` workflows fails if the PR has no prdoc. Add a few checks everytime we assume a prdoc exists. ## Integration N/A ## Review Notes N/A Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Follow-up to #8877 and audits: Make it such that invulnerable accounts cannot be ejected from the election signed queue altogether. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
This PR backport regular version bumps and prdocs reordering from the stable2506 branch back to master
…#9201) # Description - log::info! the error of accessing `GetParachainInfo::parachain_id()` runtime api if any, before reading the `para_id` from the chain specification (relevant for debugging). - removes comments/deprecation notices throughout the code that introduce `para-id` flag removal (from chain-spec-builder and support for parsing it from chain specifications) Closes #9217 ## Integration N/A ## Review Notes N/A --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sebastian Kunert <mail@skunert.dev> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
- Update some serde encoding for eth-rpc to match serialization behavior of Geth - Add support for serializing / deserializing EIP7702 tx types - Disable transaction type we don't support yet in try_ino_unchecked_extrinsics --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR: - improves `take_first_concatenated_xcm()` avoiding the XCM re-encoding - makes the benchmarks for `take_first_concatenated_xcm()` more granular, accounting for the number of bytes of the message --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Society pallet supports non-consecutive block provider Society pallet correctly handles situations where `on_initialize` is invoked with block numbers that: - increase but are not strictly consecutive (e.g., jump from 5 → 10), or - are repeated (e.g., multiple blocks are built at the same Relay Chain parent block, all reporting the same BlockNumberProvider value). This situation may occur when the BlockNumberProvider is not local - for example, on a parachain using the Relay Chain block number provider. --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
added a commit
that referenced
this pull request
Sep 2, 2025
Replace #9506 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
lrubasze
pushed a commit
that referenced
this pull request
Sep 17, 2025
Replace #9506 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Replace #9506 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
pgherveou
pushed a commit
that referenced
this pull request
Dec 5, 2025
Replace #9506 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
zombienet-sdkto latest version.Thx!
cc: @AndreiEres