Enable TopicIdTracker to support multiple flows#9316
Merged
raymondkfcheung merged 14 commits intomasterfrom Aug 20, 2025
Merged
Enable TopicIdTracker to support multiple flows#9316raymondkfcheung merged 14 commits intomasterfrom
TopicIdTracker to support multiple flows#9316raymondkfcheung merged 14 commits intomasterfrom
Conversation
raymondkfcheung
added
T6-XCM
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
1 similar comment
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
Contributor
|
Command "prdoc --audience runtime_dev --bump patch" has failed ❌! See logs here |
x3c41a
reviewed
Aug 19, 2025
| let mq_prc_id = find_mq_processed_id::<AssetHubRococo>().expect("Missing Processed Event"); | ||
| topic_id_tracker.insert_and_assert_unique("AssetHubRococo", mq_prc_id); | ||
| let mq_prc_ids = find_all_mq_processed_ids::<AssetHubRococo>(); | ||
| assert!(mq_prc_ids.len() >= 1, "Missing Processed Event on AssetHubRococo"); |
Contributor
There was a problem hiding this comment.
nit: assert1(mq_prc_ids.len() > 0, ...) - easier to comprehend
Contributor
Author
There was a problem hiding this comment.
Changed to assert!(!mq_prc_ids.is_empty(), ...
x3c41a
approved these changes
Aug 19, 2025
…-enable-multi-flows
rosarp
reviewed
Aug 19, 2025
cumulus/parachains/integration-tests/emulated/common/src/xcm_helpers.rs
Outdated
Show resolved
Hide resolved
rosarp
approved these changes
Aug 20, 2025
pepoviola
pushed a commit
that referenced
this pull request
Aug 26, 2025
This PR enables `TopicIdTracker` to support multiple flows. Continues on #9313 Closes #8676 to fix #8326 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrii <[email protected]>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
This PR enables `TopicIdTracker` to support multiple flows. Continues on #9313 Closes #8676 to fix #8326 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrii <[email protected]>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
TopicIdTrackerto support multiple flows.Continues on #9313
Closes #8676 to fix #8326