Skip to content

[AHM] Relax the requirement for RC-Client to receive +1 session reports#8702

Merged
kianenigma merged 10 commits intomasterfrom
kiz-kill-last-ending-session-index
Jun 4, 2025
Merged

[AHM] Relax the requirement for RC-Client to receive +1 session reports#8702
kianenigma merged 10 commits intomasterfrom
kiz-kill-last-ending-session-index

Conversation

@kianenigma
Copy link
Copy Markdown
Contributor

Something that we learned in westend: if ah-client decides to go to Buffered mode ever again, it might skip some sessions. Atm, we were enforcing sessions to be strictly incremented by one once received by RC client. This could cause us to drop some validator reward points.

As a simple fix, this PR relaxes this check such that if the last repot was x:

  1. x+1 is our expected behavior
  2. x+2 and more is still accepted, but we emit warning events
  3. x and below is still dropped. This can only happen due to: unforeseen bug in RC, or XCM failing to send messages in order.

@kianenigma kianenigma requested a review from a team as a code owner May 29, 2025 10:13
@kianenigma
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --bump patch

@kianenigma kianenigma added the T2-pallets This PR/Issue is related to a particular pallet. label May 29, 2025
@kianenigma kianenigma changed the title relax the requirement for RC-Client to receive +1 session reportts [AHM] Relax the requirement for RC-Client to receive +1 session reportts May 29, 2025
@kianenigma kianenigma changed the title [AHM] Relax the requirement for RC-Client to receive +1 session reportts [AHM] Relax the requirement for RC-Client to receive +1 session reports May 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2025

Command "prdoc --bump patch --audience runtime-dev" has failed ❌! See logs here

Copy link
Copy Markdown
Contributor

@sigurpol sigurpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kianenigma kianenigma enabled auto-merge June 4, 2025 21:03
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15452689951
Failed job name: fmt

@kianenigma
Copy link
Copy Markdown
Contributor Author

/cmd fmt

@kianenigma kianenigma added this pull request to the merge queue Jun 4, 2025
auto-merge was automatically disabled June 4, 2025 23:04

Pull Request is not mergeable

Merged via the queue into master with commit 3ff2859 Jun 4, 2025
244 checks passed
@kianenigma kianenigma deleted the kiz-kill-last-ending-session-index branch June 4, 2025 23:39
pgherveou pushed a commit that referenced this pull request Jun 11, 2025
…ts (#8702)

Something that we learned in westend: if `ah-client` decides to go to
`Buffered` mode ever again, it might skip some sessions. Atm, we were
enforcing sessions to be strictly incremented by one once received by RC
client. This could cause us to drop some validator reward points.

As a simple fix, this PR relaxes this check such that if the last repot
was `x`:

1. x+1 is our expected behavior
2. x+2 and more is still accepted, but we emit warning events
3. x and below is still dropped. This can only happen due to: unforeseen
bug in RC, or XCM failing to send messages in order.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ordian added a commit that referenced this pull request Jun 12, 2025
* master: (62 commits)
  release/build-macos-binaries: add missing FEATURES argument  (#8816)
  Add XCM Precompile to `pallet-xcm` (#8693)
  [Release|CI/CD] Exclude test runtimes from the runtimes build (#8820)
  Add freebsd sysinfo for telemetry (#7985)
  release-reusable-rc-build: add optional `features` input that can be considered for nodes building (#8755)
  [Staking] Cleanups and some improvements (#8701)
  Fix typos in 3 files in Implementers Guide (#8799)
  Update `RemoteExporter` docs to reflect removal of `forward_id_for` (#8795)
  Snowbridge: enforce fee when registering Polkadot native asset (#8725)
  Bump the ci_dependencies group across 1 directory with 7 updates (#8788)
  Docker hub 'master' image short sha (#8790)
  [Release|CI/CD] Combine branch-off and RC automation flows (#8754)
  Move Transaction depth limit checks (#8750)
  Add genesis presets for remaining runtimes in polkadot-parachain-bin (#8426)
  Do not make pallet-identity benchmarks signature-dependent (#8179)
  Introduction of Approval Slashes [Disabling Strategy Stage 4] (#6827)
  [AHM] Prepare For Westend Cleanup (#8715)
  Actually use RP offset in YAP parachain (#8745)
  [AHM] Relax the requirement for RC-Client to receive +1 session reports (#8702)
  Don't read storage items in logging (#8749)
  ...
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
…ts (#8702)

Something that we learned in westend: if `ah-client` decides to go to
`Buffered` mode ever again, it might skip some sessions. Atm, we were
enforcing sessions to be strictly incremented by one once received by RC
client. This could cause us to drop some validator reward points.

As a simple fix, this PR relaxes this check such that if the last repot
was `x`:

1. x+1 is our expected behavior
2. x+2 and more is still accepted, but we emit warning events
3. x and below is still dropped. This can only happen due to: unforeseen
bug in RC, or XCM failing to send messages in order.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants