Add freebsd sysinfo for telemetry by firegrass · Pull Request #7985 · paritytech/polkadot-sdk

firegrass · 2025-03-21T00:23:47Z

Description

Gathering hardware information on FreeBSD

Integration

N/A (I think)

Review Notes

Please note FreeBSD does not use the linux kernel, nor is it's kernel versioned differently as in linux distros.

Checklist

My PR includes a detailed description as outlined in the "Description" and its two subsections above.
My PR follows the labeling requirements of this project (at minimum one label for T required)
- External contributors: ask maintainers to put the right label on your PR.
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

You can remove the "Checklist" section once all have been checked. Thank you for your contribution!

✄ -----------------------------------------------------------------------------

cla-bot-2021 · 2025-03-21T00:23:54Z

User @firegrass, please sign the CLA here.

substrate/client/sysinfo/src/sysinfo_freebsd.rs

bkchr · 2025-03-31T13:46:23Z

@firegrass could you answer the questions?

firegrass · 2025-03-31T16:33:47Z

@firegrass could you answer the questions?

@bkchr sorry for the delay. I need to make a few code changes to improve physical cores counting.

firegrass · 2025-04-24T11:47:07Z

substrate/client/sysinfo/src/sysinfo_freebsd.rs

+        sysinfo.cpu = Some(cpu_model);
+    }
+
+    if let Some(cores) = sysctl_output("kern.smp.cores") {


I have changed this from hw.ncpu to kern.smp.cores consistently handle SMP regardless of how it is configured in the bios. I have tested this on our available freebsd hosts and hardware.

firegrass · 2025-04-24T11:51:37Z

Hey @bkchr - I have replied to your comments. TIA.

koute

LGTM

firegrass · 2025-05-02T04:08:00Z

LGTM

Thanks @koute. Anything you need from me? Or is this just waiting for a second reviewer?

koute · 2025-05-02T06:12:51Z

You need one more review, the CI tests need to pass, and I think you might also need a prdoc.

lexnv

LGTM! A few CI chores to make the testing pass:

bkchr · 2025-05-02T18:43:32Z

@firegrass we need a prdoc. Also the formatting isn't correct. We can not push to your branch because it belongs to some organization. So, you need to do this.

github-actions · 2025-06-10T18:35:54Z

Review required! Latest push from author must always be reviewed

firegrass · 2025-06-10T18:58:15Z

@bkchr sorry for the delay - PR should be good to merge now. Thanks 🙏

bkchr · 2025-06-10T19:34:20Z

@firegrass Ser, sorry to tell you that the cargo fmt job is still not happy 🙈

substrate/client/sysinfo/src/sysinfo_freebsd.rs

firegrass · 2025-06-10T19:44:50Z

@bkchr sorry, I had to force pushed again. Fighting GitHub for GPG 'Verified'

# Description Gathering hardware information on FreeBSD ## Integration N/A (I think) ## Review Notes Please note FreeBSD does not use the linux kernel, nor is it's kernel versioned differently as in linux distros. # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) You can remove the "Checklist" section once all have been checked. Thank you for your contribution! ✄ -----------------------------------------------------------------------------

* master: (62 commits) release/build-macos-binaries: add missing FEATURES argument (#8816) Add XCM Precompile to `pallet-xcm` (#8693) [Release|CI/CD] Exclude test runtimes from the runtimes build (#8820) Add freebsd sysinfo for telemetry (#7985) release-reusable-rc-build: add optional `features` input that can be considered for nodes building (#8755) [Staking] Cleanups and some improvements (#8701) Fix typos in 3 files in Implementers Guide (#8799) Update `RemoteExporter` docs to reflect removal of `forward_id_for` (#8795) Snowbridge: enforce fee when registering Polkadot native asset (#8725) Bump the ci_dependencies group across 1 directory with 7 updates (#8788) Docker hub 'master' image short sha (#8790) [Release|CI/CD] Combine branch-off and RC automation flows (#8754) Move Transaction depth limit checks (#8750) Add genesis presets for remaining runtimes in polkadot-parachain-bin (#8426) Do not make pallet-identity benchmarks signature-dependent (#8179) Introduction of Approval Slashes [Disabling Strategy Stage 4] (#6827) [AHM] Prepare For Westend Cleanup (#8715) Actually use RP offset in YAP parachain (#8745) [AHM] Relax the requirement for RC-Client to receive +1 session reports (#8702) Don't read storage items in logging (#8749) ...

# Description Gathering hardware information on FreeBSD ## Integration N/A (I think) ## Review Notes Please note FreeBSD does not use the linux kernel, nor is it's kernel versioned differently as in linux distros. # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) You can remove the "Checklist" section once all have been checked. Thank you for your contribution! ✄ -----------------------------------------------------------------------------

firegrass requested a review from koute as a code owner March 21, 2025 00:23

koute reviewed Mar 21, 2025

View reviewed changes

substrate/client/sysinfo/src/sysinfo_freebsd.rs Outdated Show resolved Hide resolved

substrate/client/sysinfo/src/sysinfo_freebsd.rs Outdated Show resolved Hide resolved

substrate/client/sysinfo/src/sysinfo_freebsd.rs Outdated Show resolved Hide resolved

koute requested a review from a team March 21, 2025 00:46

firegrass mentioned this pull request Mar 21, 2025

sysinfo is not captured on FreeBSD #7984

Open

2 tasks

firegrass marked this pull request as draft March 31, 2025 16:33

firegrass force-pushed the add-freebsd-sysinfo branch from dcdb076 to 1ce1e78 Compare April 24, 2025 11:21

firegrass commented Apr 24, 2025

View reviewed changes

firegrass marked this pull request as ready for review April 24, 2025 11:59

koute approved these changes Apr 24, 2025

View reviewed changes

koute requested a review from a team May 2, 2025 06:13

lexnv approved these changes May 2, 2025

View reviewed changes

bkchr added the T0-node This PR/Issue is related to the topic “node”. label May 2, 2025

bkchr approved these changes May 2, 2025

View reviewed changes

github-actions bot requested review from bkchr, koute and lexnv June 10, 2025 18:35

firegrass force-pushed the add-freebsd-sysinfo branch 4 times, most recently from d8ced9d to 4004bcf Compare June 10, 2025 18:56

firegrass force-pushed the add-freebsd-sysinfo branch from 4004bcf to 5fce876 Compare June 10, 2025 19:00

firegrass force-pushed the add-freebsd-sysinfo branch from 5fce876 to 798c00c Compare June 10, 2025 19:06

bkchr reviewed Jun 10, 2025

View reviewed changes

substrate/client/sysinfo/src/sysinfo_freebsd.rs Outdated Show resolved Hide resolved

firegrass force-pushed the add-freebsd-sysinfo branch from 798c00c to 526c9b8 Compare June 10, 2025 19:41

github-actions bot requested a review from bkchr June 10, 2025 19:42

Add freebsd sysinfo for telemetry

64e9130

firegrass force-pushed the add-freebsd-sysinfo branch from 526c9b8 to 64e9130 Compare June 10, 2025 19:43

bkchr approved these changes Jun 10, 2025

View reviewed changes

bkchr added this pull request to the merge queue Jun 10, 2025

Merged via the queue into paritytech:master with commit 934d513 Jun 10, 2025
244 of 245 checks passed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

Conversation

firegrass commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Integration

Review Notes

Checklist

Uh oh!

cla-bot-2021 bot commented Mar 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr commented Mar 31, 2025

Uh oh!

firegrass commented Mar 31, 2025

Uh oh!

firegrass Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

firegrass commented Apr 24, 2025

Uh oh!

koute left a comment

Choose a reason for hiding this comment

Uh oh!

firegrass commented May 2, 2025

Uh oh!

koute commented May 2, 2025

Uh oh!

lexnv left a comment

Choose a reason for hiding this comment

Uh oh!

bkchr commented May 2, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

firegrass commented Jun 10, 2025

Uh oh!

bkchr commented Jun 10, 2025

Uh oh!

Uh oh!

firegrass commented Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

firegrass commented Mar 21, 2025 •

edited

Loading